lsm / neokai / 25846753320

81%

push

github

fix: address P2 review comments on process cleanup (#1890) (#1896)

* fix: address P2 review comments on process cleanup (#1890)

Three fixes from post-merge review:

1. Watchdog: signal process groups (via pgid) when killing suspicious
   processes, reaching tool grandchildren that the parent may not have
   forwarded signals to.

2. AgentSession: aggregate no-PID exit promises alongside existing
   numeric-PID promises instead of overwriting processExitedPromise,
   which caused stop() to wait on the wrong promise during restart.

3. SessionManager: preserve exited root PIDs at the manager level when
   sessions are evicted from cache (interruptInMemorySession /
   unregisterSession), preventing ownership attribution loss before the
   15-minute retention window expires.

* fix: preserve live PID retention from actual exit time

Move preserveExitedRootPids to after cleanup() in interruptInMemorySession
so the retention window starts from actual process exit time, not eviction
time. cleanup() awaits process exit, so live PIDs will have transitioned to
the exited set with their real exit timestamps.

* fix: address four P2 review comments on PR #1896

1. Durable no-PID exit promises: store in noPidExitPromises array with
   self-cleaning on resolve; include in updateProcessExitedPromise() so
   later numeric-PID tracking never drops pending no-PID promises.

2. Live vs exited root distinction: SessionManager now maintains
   evictedLiveRootPids (Set) and evictedExitedRootPids (Map). Live PIDs
   are returned as live so collectDescendantPids doesn't skip them as
   PID-reuse false positives. Moved preserveRootPids to after cleanup()
   so retention starts from actual exit time.

3. Group kill error isolation: wrap killProcessGroup in its own try/catch
   so a throwing group killer doesn't prevent the fallback direct-PID
   SIGTERM.

Added regression tests for no-PID-first-then-numeric, multiple no-PID,
evicted live root in snapshot, and throwing killPr... (continued)

8333 of 11605 branches covered (71.81%)

Branch coverage included in aggregate %.

147 of 149 new or added lines in 6 files covered. (98.66%)

66750 of 79451 relevant lines covered (84.01%)

292.03 hits per line