lsm / neokai / 25884037273

81%

push

github

fix: route task/node agent replies to originating session (#1900)

* fix: route task/node agent replies to originating session

When an ad-hoc space member session (non-space:chat:) uses
send_message_to_task to message a task/node agent, the reply now routes
back to the originating session instead of always going to
space:chat:${spaceId}.

- Add ReplyRoutingRegistry for tracking which session sent messages to
  each task/node
- Add replyToSessionId field to formatAgentMessage envelope with
  machine-readable XML footer
- Update spaceAgentInjector to accept optional replyToSessionId
- Wire replyRoutingLookup through task-agent-tools and
  AgentMessageRouter for both task-agent and node-agent send_message
- Register replyToSessionId in send_message_to_task before injection
- Full backward compat: no registry lookup returns space:chat: default

* fix: wire reply routing in send_message_to_task, AgentMessageRouter, and rehydration paths

Three gaps in the initial reply-routing implementation:

1. space-agent-tools: `replyRoutingRegistry` was accepted in config but
   never destructured or consumed. Now `send_message_to_task` registers
   the caller's session ID before each delivery path (task-agent direct,
   node-agent direct, node-agent post-activation, node-agent queued) so
   replies route back to the originating session.

2. AgentMessageRouter: `replyRoutingLookup` was not passed to the router
   constructed in `buildNodeAgentMcpServerForSession`, so node-agent
   `send_message({ target: 'space-agent' })` always fell back to
   `space:chat:${spaceId}`. Now wired with a `(fromAgentName) =>
   registry.get(taskId, fromAgentName)` lookup.

3. Rehydration: `rehydrateTaskAgent` did not pass `replyRoutingLookup`
   to `createTaskAgentMcpServer` or `replyRoutingRegistry` to
   `createSpaceAgentMcpServer`, so tasks restored after daemon restart
   lost reply routing. Both are now wired. Also added
   `replyRoutingRegistry` to `buildSpaceAgentToolsMcpServerFo... (continued)

8334 of 11605 branches covered (71.81%)

Branch coverage included in aggregate %.

95 of 118 new or added lines in 8 files covered. (80.51%)

66961 of 79731 relevant lines covered (83.98%)

291.86 hits per line