lsm / neokai / 25615959391

82%

Build Type

push

github

Committed by web-flow

Commit Message

feat: add Create Session and Create Task buttons to Space pages (#1838)

* feat: add Create Session and Create Task buttons to Space pages

- Add `actions` slot to SpacePageHeader for contextual header buttons
- Wire "Create Session" button on Space Sessions page via createSession() API
- Wire "Create Task" button on Space Tasks page via SpaceCreateTaskDialog
- Move `space` signal read before handleCreateSession to fix TDZ issue

* fix: address review feedback on create buttons

- Add creatingSession loading state to prevent duplicate session creation
- Surface session-creation errors via toast.error instead of swallowing
- Guard post-create task navigation with currentSpaceViewModeSignal check
  to avoid stale async redirects if user navigated elsewhere

* fix: guard against stale async redirects and dialog state leak

- Verify currentSpaceIdSignal matches origin space before navigating
  after both session creation and task creation
- Reset createTaskOpen when viewMode or spaceId changes away from Tasks
  to prevent dialog reopening unexpectedly on return

* fix: reset session lock on space change and gate nav to Sessions route

- Reset creatingSession to false via useEffect when spaceId changes,
  preventing cross-space lockout from a stale in-flight request
- Capture originViewMode before async createSession and verify both
  currentSpaceIdSignal and currentSpaceViewModeSignal match before
  navigating, avoiding stale redirects when user leaves Sessions view

* fix: address round-4 review feedback and add tests

- Reset creatingSession lock via useEffect when spaceId changes
- Gate post-create session navigation on both spaceId and viewMode
- Reorder hook declarations: useState before useEffect
- Add 7 unit tests covering:
  - Create Session button renders and calls createSession
  - Navigation on success, toast.error on failure
  - Stale-redirect guard (different space)
  - Button disabled state during async creation
  - Create Task button render... (continued)

Coverage Stats

8209 of 11392 branches covered (72.06%)

Branch coverage included in aggregate %.

30 of 34 new or added lines in 1 file covered. (88.24%)

166 existing lines in 7 files now uncovered.

63934 of 76032 relevant lines covered (84.09%)

262.28 hits per line