lsm / neokai / 25604478977

82%

push

github

Extract Channels and ClientEventGateway foundation (#1824)

* feat: add Channels and ClientEventGateway foundation

Introduce typed channel construction and a client-event delivery seam so
new code can target client-facing broadcasts without inlining wire-level
channel strings or coupling to MessageHub directly.

- packages/shared/src/message-hub/channels.ts: EventChannel ADT, Channels
  factories, and a default ChannelRegistry that serializes/parses to the
  existing wire strings (global, session:id, room:id, space:id,
  workflowRun:spaceId:workflowRunId, task:spaceId:taskId).
- packages/shared/src/message-hub/client-event-gateway.ts: thin gateway
  that accepts an EventChannel, serializes via the registry, and delegates
  to MessageHub.event(...). Structural ClientEventSink keeps it test-friendly.
- packages/daemon/src/lib/state-manager.ts: migrate session.created,
  session.deleted, and context.updated forwarding behind the gateway as a
  proof of pattern. channelVersions and the rest of StateManager are kept
  as-is to keep this PR low-conflict.
- Tests cover registry round-trips, malformed inputs, and gateway
  forwarding including a custom registry and global helper.

* test: cover ClientEventGateway DI seam; simplify hub type

P2: Add a new "ClientEventGateway DI seam" describe block in
state-manager.test.ts that injects a spied IClientEventGateway, drives
the EventBus, and asserts session.created/session.deleted/context.updated
flow through the gateway with typed EventChannel descriptors. Also covers
the default-gateway fallback path so the seam is documented end-to-end.

P3: Drop the redundant ClientEventSink | MessageHub union from
ClientEventGatewayOptions.hub. MessageHub structurally satisfies
ClientEventSink, so the union added a transport import without buying
anything; removing it keeps client-event-gateway.ts free of MessageHub
dependencies, matching the doc comment.

8195 of 11374 branches covered (72.05%)

Branch coverage included in aggregate %.

92 of 92 new or added lines in 4 files covered. (100.0%)

64011 of 75950 relevant lines covered (84.28%)

289.63 hits per line