lsm / neokai / 25616140083

82%

push

github

fix(space): keep open tasks open when a dependency fails (#1834)

* fix(space): keep open tasks open when a dependency fails

`blockDependentTasks` previously cascaded `dependency_failed` to all `open`
tasks that pointed to the failed task. This breaks daemon restart recovery:
a stalled `in_progress` run gets flagged `blocked`, and every open task that
was simply waiting on it is also marked `blocked` and never auto-starts when
the dependency eventually completes.

The runtime already skips open tasks with unmet dependencies via
`areDependenciesMet()`, so the cascade only needs to abort tasks that
already have a workflow run attached — i.e. `in_progress` tasks. Open tasks
should stay `open` and be picked up naturally on the next tick.

Updates the cascade tests to cover the new semantics and adds a regression
test for the daemon-restart scenario.

* fix(space): split cascade by parent status; skip blocked in completion path

Addresses two review concerns on the dependency-cascade fix:

- Cancellation propagation (P2): cancelled parents are terminal-but-
  restartable, so dependents must transition out of `open`/`in_progress` —
  otherwise they wait forever on a parent that will never reach `done`.
  Adds `cancelDependentTasks` (cascades `cancelled`) alongside the existing
  `blockDependentTasks` (cascades `blocked`); `updateTaskAndEmit` now picks
  the right cascade based on the parent's terminal status.

- Completion-path safety for cascade-blocked tasks (P1): a task that was
  cascade-blocked while its workflow run was still alive could be pushed
  through `dispatchPostApproval` on run completion, which attempts an
  invalid `blocked → approved` transition. Adds `blocked` to the
  already-resolved skip set in both the active-tick guard
  (`taskAlreadyResolved`) and the terminal-run reconciler.

Tests: new cascade tests for `cancelDependentTasks`; new runtime
completion test asserting a `blocked` canonical task is left alone when
its run finishes.

*... (continued)

8210 of 11392 branches covered (72.07%)

Branch coverage included in aggregate %.

52 of 52 new or added lines in 2 files covered. (100.0%)

64096 of 76029 relevant lines covered (84.3%)

289.49 hits per line