IJHack / QtPass / 25588780598

55%

Build Type

push

github

Committed by web-flow

Commit Message

feat: auto-probe + override for SSH_AUTH_SOCK (closes #543) (#1438)

* feat: auto-probe + override for SSH_AUTH_SOCK (closes #543)

Long-standing pain point: GUI-launched QtPass doesn't inherit shell-set
environment variables (SSH_AUTH_SOCK, GPG_TTY, etc.) from .bashrc/.zshrc.
Users with gpg-agent's SSH support — particularly YubiKey + GPG SSH auth —
hit "git push/pull" failures when they launch QtPass from the GNOME app
launcher / macOS Dock instead of a terminal. Issue #543 documents this
across multiple distros and the macOS side.

Resolution:

New Util::initialiseSshAuthSock(), called from main() before any
subprocess work happens. Resolution order:

1. If SSH_AUTH_SOCK is already set (terminal launch, .desktop Exec=
   override, parent process), do nothing.
2. If a sshAuthSockOverride setting is configured in QtPass, use it.
3. Probe `gpgconf --list-dirs agent-ssh-socket` (canonical for gpg-agent's
   SSH support).
4. On macOS, fall back to `launchctl getenv SSH_AUTH_SOCK`.

Sets via qputenv() so child processes (git, pass) inherit it.

Settings:

- New QtPassSettings::getSshAuthSockOverride() / setSshAuthSockOverride()
  with corresponding settingsconstants::sshAuthSockOverride key.
- New configdialog.ui field on the Programs tab — labelled
  "SSH_AUTH_SOCK override:" with placeholder text "(auto-probe via
  gpgconf)" and a tooltip referencing the issue. Empty value means
  "auto-probe is fine".

Tests (tests/auto/util/tst_util.cpp):

- sshAuthSockOverrideRoundtrip — getter/setter persistence
- sshAuthSockOverrideEmptyByDefault — default value behaviour
- initialiseSshAuthSockHonoursExistingEnv — env-already-set wins over
  override and over auto-probe (terminal-launch users keep their setup)
- initialiseSshAuthSockUsesOverride — override applied when env unset
- initialiseSshAuthSockOverrideWinsOverProbe — override beats gpgconf
  even on systems where gpgconf would have provided a value
- initialiseSshAuthSockNoOverrideNoEnvProbes — auto-probe... (continued)

Coverage Stats

31 of 33 new or added lines in 3 files covered. (93.94%)

193 existing lines in 2 files now uncovered.

1886 of 6662 relevant lines covered (28.31%)

27.18 hits per line