IJHack / QtPass / 25612087677

55%

Build Type

push

github

Committed by web-flow

Commit Message

fix(ssh-auth-sock): warn when override path looks bogus (#1439)

* fix(ssh-auth-sock): warn user when override path looks bogus

Two reviewer findings on the SSH_AUTH_SOCK override path (post-merge of
#1438):

- src/util.h: doc tweak — clarify that the "no validation" line refers
  to the runtime environment-setup step. The Settings dialog now does a
  soft check at save time.

- src/configdialog.cpp: when the user types a non-empty override and
  saves, do a soft check before writing the setting:
  - QFileInfo::exists() and isReadable()
  - on Unix, stat() + S_ISSOCK to confirm it's a Unix domain socket
    (Windows ssh-agent uses a named pipe, so we skip the socket check
    there)

  When any check fails, show a non-blocking QMessageBox::warning telling
  the user the path looks invalid and that the value will still be saved
  as entered. This preserves the "QtPass trusts the user choice" stance
  (e.g. user might start their agent after launching QtPass) while
  giving immediate feedback on typos. The runtime probe in
  Util::initialiseSshAuthSock() is unchanged — it still uses the
  override verbatim, no ssh-add validation, matching the existing
  contract.

No new tests: the warning is a UI-side soft check on data the user just
typed, with no side effects beyond the dialog. The existing
initialiseSshAuthSockOverrideSkipsAgentValidation test continues to
verify the runtime "no validation" contract.

lupdate refreshed the .ts files to pick up the four new tr() strings
(dialog title + 3 reasons + body template).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* fix: apply CodeRabbit auto-fixes

Fixed 17 file(s) based on 18 unresolved review comments.

Co-authored-by: CodeRabbit <noreply@coderabbit.ai>

* i18n: drop generated ui_*.h locations + 3 reviewer fixes

distclean+qmake6 regenerated the .ts files without the spurious
location pointers into generated headers (ui_configdialog.h,
ui_mainwindow.h, etc.) that lupdate had ca... (continued)

Coverage Stats

0 of 19 new or added lines in 1 file covered. (0.0%)

9 existing lines in 1 file now uncovered.

1888 of 6680 relevant lines covered (28.26%)

27.11 hits per line