IJHack / QtPass / 25581862009

55%

push

github

refactor(util): use raw-string literal for endsWithGpg regex (#1437)

"\\.gpg$" → R"(\.gpg$)". Same regex, fewer backslashes.

Skipped three other reviewer findings on this round (all repeats
of the concurrency-primitives suggestion that was already
rejected in #1436):

- "Add std::call_once around initialiseEnvironment": codebase has
  no other locking primitives, all access is from the GUI thread.
  Same reasoning as #1436's wslBinaryCache rejection.

- "Add QMutex around wslBinaryCache": ditto. The cache is only
  reached from findBinaryInPath, which is called from the main
  thread.

- "Static initialization of wslAvailable not thread-safe in
  C++03/98": project is C++17 (qtpass.pri sets CONFIG += c++17),
  C++11+ guarantees thread-safe magic statics. Moot.

Tests: tst_util 106/106 pass.

1 of 1 new or added line in 1 file covered. (100.0%)

1855 of 6617 relevant lines covered (28.03%)

27.11 hits per line