lsm / neokai / 25588377420

82%

push

github

fix: thread image uploads through space task message pipeline (#1829)

* fix: thread image uploads through space task message pipeline

Images attached in the space thread composer and slide-out chat were
silently dropped on send. The composer collected the images, but every
layer between it and the SDK ignored them:

- TaskSessionChatComposer dropped the images param when delegating to
  onSend
- SpaceTaskPane.sendThreadMessage and AgentOverlayChat both forwarded
  text-only payloads to spaceStore.sendTaskMessage
- spaceStore.sendTaskMessage and the space.task.sendMessage RPC handler
  had no images parameter
- task-agent-manager.injectMessageIntoSession built a text-only
  SDKUserMessage even when images were present
- ChatContainer.sendChatContainerMessage refused to send when images
  were attached, surfacing a misleading "not yet supported" toast

Thread MessageImage[] from composer → store → RPC → daemon, and build
a multi-modal MessageContent array (image blocks first, then text)
matching the existing non-space chat path. Surface an explicit error
when images are sent to a not-yet-spawned workflow agent rather than
silently dropping them, since the pending-message queue is text-only.

* fix: validate task-thread images and preserve attachments on send failure

Address PR review feedback:

1. Server-side image-size validation for the task-message path.
   `space.task.sendMessage` was forwarding base64 attachments straight into
   `injectMessageIntoSession` with no size check, so oversized payloads
   were persisted/queued and only failed later in the SDK with an opaque
   API error. Extract the existing 5MB guard from `MessagePersistence` into
   a reusable `validateImageSizes` helper and call it from both the live-
   session path (unchanged behavior) and `injectMessageIntoSession`, so
   task-thread sends now return the same early "resize image" error.

2. Preserve attachments when an override-routed send fails.
   `MessageInput.handleSubmit` ... (continued)

8194 of 11374 branches covered (72.04%)

Branch coverage included in aggregate %.

68 of 76 new or added lines in 7 files covered. (89.47%)

63791 of 75693 relevant lines covered (84.28%)

289.05 hits per line