lsm / neokai / 25587075236

82%

Build Type

push

github

Committed by web-flow

Commit Message

fix: reduce idle web/daemon churn (live-query, polling, file-index) (#1830)

* fix: stop session.messages.byStatus polling when agent is idle

* fix: remove broken queued-messages polling from MessageInput

* fix: reduce idle live-query and file-index churn

* test: align scope and ChatComposer tests with idle-perf changes

- scoped-invalidation: createSession now propagates scope (sessionId,
  sessionType, optional roomId/spaceId/taskId from session.context); the
  old "does NOT carry scope" expectation contradicted the intentional
  fix in 41c0b7cc3. Replaced with two cases: scope populated from
  context, and scope minimal when context is absent.
- ChatComposer: drop the two queue-shortcut assertions and the
  canQueueMessages prop on the MessageInput mock. The prop was removed
  in 77d72146c when the broken queued-messages flow was deleted.

* fix: address review feedback on idle-perf scope filters and dead code

Review feedback fixes:

- live-query-handlers: scope filters
  - Remove `buildSessionsListScopeFilter` entirely. The previous filter
    rejected post-update scopes whose `roomId/spaceId` were set or whose
    sessionType was excluded, but `updateSession` scope reflects the
    *post*-write row. A session transitioning visible→hidden (e.g. via
    `AgentSession.fromInit` setting `context.spaceId`) would be filtered
    out and leave a stale row in `sessions.list`. Session writes are
    infrequent vs. sdk_messages, so unconditional re-evaluation is the
    correct trade-off.
  - `buildSpaceSessionsScopeFilter` no longer snapshots
    `spaces.session_ids` at subscribe time. Membership is now read
    live on each invalidation via a prepared statement, so:
      * sessions added to the space after subscription are immediately
        in scope (previously missed updates until reconnect)
      * sessions removed from the space stop matching without requiring
        a resubscribe
    Scopes that explicitly carry `spaceId === ourSpaceId` short... (continued)

Coverage Stats

8195 of 11372 branches covered (72.06%)

Branch coverage included in aggregate %.

83 of 86 new or added lines in 4 files covered. (96.51%)

4 existing lines in 1 file now uncovered.

63753 of 75647 relevant lines covered (84.28%)

289.15 hits per line