lsm / neokai / 25589170979

82%

Build Type

push

github

Committed by web-flow

Commit Message

fix: plan & decompose workflow runtime, gate, and prompt issues (#1828)

* fix: plan & decompose workflow runtime, gate, and prompt issues

Six interlocking issues prevented the Plan & Decompose workflow from
completing on its own:

- ChannelRouter.deliverMessage activated the target node before
  evaluating the channel's gate, so the tick loop spawned sessions for
  blocked nodes (e.g. Task Dispatcher firing before all 4 reviewers
  had voted on plan-approval-gate). Gate evaluation now runs first;
  activation only happens once the gate is open.
- Auto-gate-write in send_message used GateDataRepository.merge, which
  shallow-merges. For map-type fields (like plan-approval-gate's
  `approvals`) each reviewer's vote replaced the whole map. The
  auto-write now deep-merges entries for any field whose definition
  has type:'map' before delegating to the repo's shallow merge, so
  each reviewer's lens entry accumulates.
- The planner prompt previously said the plan-pr-gate would "verify"
  the PR automatically without telling the planner to send the
  pr_url. Without an explicit send, the gate stayed closed and Plan
  Review never started. The prompt now mandates
  `send_message(target="Plan Review", data: { pr_url })` and notes
  the resetOnCycle behaviour.
- Reviewer prompts claimed the terminal-action tools were
  unavailable, which is incorrect — they are registered for every
  node-agent session. The wording now states they are technically
  available but STRICTLY off-limits for reviewers (calling them would
  close the run prematurely) and reserves them for the Task
  Dispatcher.
- Lens-specific reviewer prompts and the central PD_PLAN_REVIEW_PROMPT
  now describe the gate-write payload as
  `data: { approvals: { "<lens>": "approved" } }` matching the actual
  field schema, instead of the legacy `reviewer_name`/`approved`
  scalar shape that the auto-gate-write would silently strip.
- plan-approval-gate's description spells out the deep-merge contra... (continued)

Coverage Stats

8193 of 11374 branches covered (72.03%)

Branch coverage included in aggregate %.

95 of 95 new or added lines in 4 files covered. (100.0%)

1 existing line in 1 file now uncovered.

63862 of 75765 relevant lines covered (84.29%)

289.89 hits per line