IJHack / QtPass / 25576477093

55%

Build Type

push

github

Committed by web-flow

Commit Message

refactor: clang-tidy cleanup (1 real bug + bulk modernize/performance fixes) (#1432)

* fix(trayicon): remove dead misleading setVisible method

TrayIcon::setVisible(bool) was a name collision with its base
class QWidget::setVisible(bool) — same signature, but the
implementation didn't toggle the tray icon's visibility. It
shows/hides the parent window:

  void TrayIcon::setVisible(bool visible) {
    if (visible) parentwin->show();
    else         parentwin->hide();
  }

Two problems:
- Misleading name: doesn't do what the QWidget API contract
  promises.
- Virtual shadowing without override: calling through a QWidget*
  pointer would call the base implementation, not this one,
  silently breaking caller intent.

Searched for callers — there are none. The method is dead code.
Removed the declaration and implementation together. Show/hide
of the parent window already happens elsewhere (via showAction
/ hideAction signals in createActions).

Caught by clang-tidy modernize-use-override.

* chore(clang-tidy): drop noisy stylistic checks

Two clang-tidy checks were producing high-volume findings that
the project doesn't actually want to fix:

- modernize-use-trailing-return-type (~55 in QtPass code, ~11K
  total counting Qt headers): suggests "auto foo() -> int"
  style. Project codebase mixes both; not enforcing the trailing
  form is a deliberate stylistic choice.

- modernize-use-nodiscard (~5 in QtPass code, ~3.7K total):
  suggests [[nodiscard]] on every getter. Project is selective
  about which getters need it; auto-applying everywhere creates
  noise and doesn't reflect intent.

Disabled both. Keeps the rest of modernize-* / performance-*
active so genuine improvements (default-member-init, override,
braced-init-list, enum-size, etc.) keep getting flagged.

Also added HeaderFilterRegex to keep findings from vendored
qprogressindicator out of the diagnostic stream.

* refactor: apply clang-tidy auto-fixes (modernize-* + performance-*)

Bulk pass o... (continued)

Coverage Stats

5 of 18 new or added lines in 12 files covered. (27.78%)

9 existing lines in 1 file now uncovered.

1854 of 6610 relevant lines covered (28.05%)

27.13 hits per line