IJHack / QtPass / 25577758329

55%

push

github

refactor(util): cleaner path construction + brace consistency (#1433)

* refactor(util): cleaner path construction + brace consistency

Two readability fixes from review:

- findPasswordStore now uses QDir(home).filePath("password-store")
  instead of homePath + separator + "..." + separator concatenation.
  Idiomatic Qt; the trailing separator concern is handled by the
  normalizeFolderPath() call that wraps the result anyway.

- findBinaryInPath: add braces around the single-line early-return
  if (binary.isEmpty()) — minor consistency win, prevents future
  add-a-debug-line bugs.

A third reviewer finding asked to refactor getFolderTemplate's
while(true) loop into a condition-based one with a firstIteration
flag. Skipped: the existing while(true) with three explicit break
statements (reached store root / went outside store / can't cdUp)
spells out three distinct exit conditions clearly; folding them
into a compound while-condition with a sentinel flag would
obfuscate rather than clarify.

Tests: tst_util passes (106 of 106), build clean.

* refactor(util): cleanPath the result of findPasswordStore

normalizeFolderPath() only adds a trailing separator and converts
to native separators — it does not collapse redundant separators
or resolve relative components. So a PASSWORD_STORE_DIR env-var
value like "~/foo//bar/../store/" passed through verbatim.

Wrap with QDir::cleanPath() before normalising. The platform
fallback paths constructed via QDir(home).filePath(...) were
already clean from QDir's perspective, so the change only matters
for the env-var case — but it's the right place to do the
cleaning for both branches.

Tests: tst_util passes 106 of 106.

* fix(util): expand leading tilde in PASSWORD_STORE_DIR

Qt's file APIs treat "~" as a literal directory name. Env vars
set outside an unquoted shell context (systemd unit Environment=,
.desktop entries, quoted assignments like
"export PASSWORD_STORE_DIR='~/foo'") skip shell tilde expansion,
so the ... (continued)

3 of 7 new or added lines in 1 file covered. (42.86%)

1854 of 6614 relevant lines covered (28.03%)

27.12 hits per line