lsm / neokai / 25535179445

82%

push

github

fix(gemini): whitelist JSON Schema keywords in tool definitions (#1818)

* fix(gemini): whitelist JSON Schema keywords in tool definitions

Replace the keyword-blacklist approach in convertSchema() with a whitelist
of only the JSON Schema keywords Gemini's Code Assist API supports.
This strips unsupported keywords like $schema, propertyNames, and
exclusiveMinimum that cause 400 errors from the Gemini API.

- Add GEMINI_SCHEMA_KEYWORDS whitelist
- Rewrite convertSchema() to keep only whitelisted keys
- oneOf is converted to anyOf during traversal
- Remove old additionalProperties deletion and oneOf→anyOf logic
- Add tests for $schema, propertyNames, exclusiveMinimum stripping
  and supported-keyword preservation

* fix(gemini): accumulate anyOf+oneOf and correct JSDoc

- When both anyOf and oneOf are present, merge them into result.anyOf
  instead of letting the last one overwrite (silent data loss).
- Update JSDoc to clarify that oneOf is converted to anyOf, not stripped.
- Add test for anyOf+oneOf accumulation.

* feat(gemini): expand model list to include Gemini 3.x and Gemma 4 models

Update the hardcoded GEMINI_MODELS list to match the models supported by
Google's Gemini CLI (source: google-gemini/gemini-cli packages/core/src/config).

Added models:
- gemini-3.1-pro-preview
- gemini-3-pro-preview
- gemini-3-flash-preview
- gemini-3.1-flash-lite-preview
- gemini-2.5-flash-lite
- gemma-4-31b-it
- gemma-4-26b-a4b-it

Removed: gemini-2.0-flash (superseded by 2.5/3.x)

Also updated:
- bridge-server /v1/models endpoint with the same list
- convertModelId() to pass through gemma-* IDs as-is

* test(gemini): fix provider tests for expanded model list

- Update ownsModel test: replace removed gemini-2.0-flash with gemini-3-pro-preview
- Update getModels test: accept both 'gemini' and 'gemma' families

* feat(gemini): dynamic model discovery via fetchAvailableModels endpoint

Replace hardcoded GEMINI_MODELS with dynamic discovery using Google's
/v1internal:... (continued)

8231 of 11408 branches covered (72.15%)

Branch coverage included in aggregate %.

299 of 304 new or added lines in 5 files covered. (98.36%)

63134 of 74970 relevant lines covered (84.21%)

289.81 hits per line