lsm / neokai / 25534038034

83%

push

github

Replace task_thread_messages projection with derived columns (#1823)

* refactor(storage): replace task_thread_messages projection with derived columns

Replace the SQLite-trigger projection table introduced in PR #1803 with a
simpler scheme that scales linearly with reads instead of write fan-out:

- Add `is_renderable`, `is_terminal`, and `parent_tool_use_id` derived
  columns to `sdk_messages`, populated at write time by the repository.
- Add a `task_session_map` table (task_id, session_id, kind, role, label,
  node_execution_id) maintained at write time by `SpaceTaskRepository`
  (task_agent leg) and `NodeExecutionRepository` (node_agent leg).
- Migration 118 backfills derived columns and rebuilds the map for
  existing data.
- Mark `task_session_map` as an internal projection — excluded from
  agent-visible scopes in `db-query/scope-config.ts`.

This removes the trigger machinery while preserving the same liveQuery
semantics, with single-table reads instead of multi-CTE walks through
sessions/space_agents/node_executions on every evaluation.

* refactor(live-query): simplify turn detection — user message ID as turnId

The task-thread liveQueries previously composed `turnId` from
`session_groups.iteration` plus the row's UUID. That coupled message
grouping to feedback-iteration metadata that the runtime stamps for a
different purpose (tracking review rounds), and required the SQL to
extract a JSON field on every row.

Replace with the simpler model:

- A "turn" = one user message + every subsequent non-user message until
  the next user message (per session).
- `turnId` = the user message's own row ID. Rows that precede any user
  message in their session fall back to their own ID.
- The compact and full liveQuery SQLs derive `turnUserMessageId` per row
  via a window-function CTE and ROW_NUMBER lookup, so the row mappers
  read it as a single column instead of computing it from JSON.

`feedbackIteration` stays in `session_groups` metadata for tra... (continued)

8231 of 11408 branches covered (72.15%)

Branch coverage included in aggregate %.

142 of 213 new or added lines in 7 files covered. (66.67%)

62864 of 74749 relevant lines covered (84.1%)

290.03 hits per line