lsm / neokai / 25536788366

82%

push

github

feat: implement ExternalEvent schema and store (#1821)

* feat: implement ExternalEvent schema and store

Add durable external-event lifecycle storage for the External Event Bus:

- New tables (migration 118):
  - space_external_events: source-level dedup + state machine
  - space_external_event_deliveries: per-subscription delivery lifecycle

- ExternalEvent types and validation:
  - ExternalEvent, ExternalEventState, ExternalEventDeliveryState
  - TERMINAL_EVENT_STATES, RETRYABLE_EVENT_STATES, TERMINAL_DELIVERY_STATES
  - validateGlobPattern() for 4-segment topic contract
  - validateSource() for known-source allow-list

- ExternalEventStore methods:
  - store() — first observation + duplicate handling (terminal short-circuit,
    retryable re-emit)
  - registerExpectedDelivery() — idempotent INSERT OR IGNORE
  - markDeliveryDelivered / markDeliveryFailed — terminal vs transient
  - markEventDeliveredIfAllDeliveriesDelivered — all delivered → delivered
  - markEventFailedIfAnyDeliveryTerminalFailed — any failed → failed
  - markEventFailedIfAllDeliveriesTerminal — all terminal + any failed → failed
  - markEventFailed / markEventIgnored — terminalization
  - updateEventState — non-terminal progression
  - getEventIdForDeliveryKey / isDeliveryTerminal

- Tests cover:
  - terminal/retryable duplicate behavior
  - expected delivery idempotency
  - delivered only when all deliveries are delivered
  - failed if any delivery terminally fails
  - validation edge cases

Store is source-agnostic and not GitHub-specific.

* fix: address review feedback on validation and edge cases

- Reject whitespace-only dedupeKey in store validation
- Validate target identifiers (workflowRunId, taskId, nodeId, agentName)
  are non-empty in registerExpectedDelivery
- Detect cross-event delivery key conflicts after INSERT OR IGNORE
- Reject mid-segment wildcards in segments 0-2 (e.g. own*, re*po)
- Add comprehensive unit tests for all new validations

* fix: add external eve... (continued)

8231 of 11408 branches covered (72.15%)

Branch coverage included in aggregate %.

472 of 472 new or added lines in 7 files covered. (100.0%)

63606 of 75442 relevant lines covered (84.31%)

289.17 hits per line