lsm / neokai / 25458927253

81%

push

github

fix(agent): expose Task/Agent tools for non-Anthropic providers (#1805)

* fix(agent): expose Task/Agent tools for non-Anthropic providers when agents are configured

The SDK's claude_code preset may omit Task from the function schema on
non-Anthropic providers even though the system prompt still describes
agents. This causes a mismatch: the model sees agent descriptions but
has no callable tool to invoke them.

Changes:
- Add ensureAgentTools() pure function that injects Task, TaskOutput,
  TaskStop into the tools list whenever agents are configured.
- For explicit tool arrays: append missing agent tools.
- For undefined tool lists on non-Anthropic providers: expand to the
  full built-in array so the bridge receives agent tools.
- Space chat sessions are exempt (they explicitly restrict Task).
- Add provider-specific tests covering Anthropic, Copilot, Codex, and
  glm providers.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* refactor(query-options): address review feedback on PR #1805

- P2-1: Deduplicate tool list by replacing inline coordinator-mode allTools
  array with the shared FULL_BUILTIN_TOOL_LIST constant.
- P2-2: Replace hardcoded provider negative-list with named
  NATIVE_AGENT_TOOL_PROVIDERS constant and explanatory JSDoc.
- P2-3: Change session type fallback from invalid 'general' to valid
  'worker' (matches SessionType union default).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* fix(query-options): preserve explicit tool arrays for native providers

The Array.isArray(tools) branch in ensureAgentTools was appending agent
invocation tools unconditionally, even for Anthropic and anthropic-copilot
providers where the SDK handles agent tools natively. This caused a behavior
regression where explicit restricted tool lists (e.g. ['Read', 'Write'])
would unexpectedly gain Task/TaskOutput/TaskStop on native providers.

Add a NATIVE_AGENT_TOOL_PROVIDERS guard to the array branch so explicit
tool arrays are preserved... (continued)

8190 of 11322 branches covered (72.34%)

Branch coverage included in aggregate %.

58 of 58 new or added lines in 1 file covered. (100.0%)

62686 of 74695 relevant lines covered (83.92%)

288.22 hits per line