lsm / neokai / 25463083680

82%

push

github

Design: external event bus for Space workflow nodes (#1777)

* Design: external event bus for Space workflow nodes

Produce a design document for routing external events (GitHub webhooks,
CI status, etc.) directly to Space workflow nodes, bypassing the current
requirement for the Space Agent to relay events to coder nodes.

Key design decisions:
- Trie-based topic matching (O(k) lookup, independent of subscription count)
- Node-level eventInterests declared as data in workflow definitions
- Auto-scoped 'task' mode: events filter to the node's associated PR/branch
  without the node author specifying PR numbers
- Adapter pattern: GitHub adapter hooks existing space.githubEvent.routed
  DaemonHub event — zero changes to SpaceGitHubService
- Delivery via sessionFactory.injectMessage with defer mode (same pattern
  as SessionNotificationSink)

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* Address review feedback on event bus design doc

P0 fix:
- Document the `action` field gap in `space.githubEvent.routed` and
  specify the fix: add `action` and `rawPayload` to appendTaskActivity

P1 fixes:
- Correct trie complexity claim: O(2^k × m), not O(1) relative to subs
- Scope `**` wildcard out of v1 with explicit note
- Add `unregisterExecution` and `clearRunInterests` methods
- Document in-memory queue limitation on daemon restart
- Add `validateGlobPattern()` helper with full validation
- Fix `task` scope to handle multi-task runs via listByWorkflowRun

P2 fixes:
- Define `isWatchedRepo` with `space_github_watched_repos` cache
- Add TTL-based dedup eviction (10-minute cap)
- Document TOCTOU race as safe (caught error, no data loss)
- Expand integration tests with concrete 2-3 sentence scenarios

P3 fixes:
- Include `rawPayload` in adapter output and DaemonHub payload
- Add `isReceivingStatus` helper implementation

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* Fix inline review feedback on event bus design

- Add nodeId to dedup key t... (continued)

8191 of 11322 branches covered (72.35%)

Branch coverage included in aggregate %.

62687 of 74695 relevant lines covered (83.92%)

288.22 hits per line