lsm / neokai / 24890604342

82%

Build Type

push

github

Committed by web-flow

Commit Message

feat(space): runtime post-approval routing + mark_complete tool (PR 2/5) (#1621)

* feat(space): runtime post-approval routing + mark_complete tool (PR 2/5)

Runtime-driven post-approval routing gated behind
NEOKAI_TASK_AGENT_POST_APPROVAL_ROUTING (OFF by default). Introduces
PostApprovalRouter that, on approved transitions, either marks the task
done (no workflow post_approval), injects [POST_APPROVAL_INSTRUCTIONS]
into the Task Agent (targetAgent='task-agent'), or spawns a fresh
node-agent sub-session. Adds mark_complete MCP tool on the Task Agent
and mirrors it onto node-agent surfaces so post-approval executors can
finalize approved → done. Keeps approve_task semantics unchanged and
always emits [TASK_APPROVED] on approval. Wires UI surface for blocked
post-approval state via new InlineStatusBanner + PendingPostApprovalBanner.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* fix(space): forward approvalReason + emit on post-approval dispatch

Review fixes for PR 2/5:

- Bug 1: `SpaceRuntime.dispatchPostApproval` was dropping
  `contextExtras.approvalReason` on the review → approved transition,
  which then let `SpaceTaskManager.setTaskStatus` stamp `null` and
  overwrite whatever the RPC handler had just written. Forward the
  value explicitly, distinguishing missing (undefined) from explicit
  clear (null). Widens `setTaskStatus` options to accept `string | null`.

- Bug 2: The no-route branch inside `PostApprovalRouter.route` closes
  the task via `taskRepo.updateTask` directly, without emitting any
  notification. The RPC path re-reads + emits after dispatch, but the
  end-node tick path had no follow-up — UI stayed stuck at `approved`
  until the next poll. `dispatchPostApproval` now re-reads and calls
  `safeOnTaskUpdated` whenever the router returns a non-`skipped`
  result, uniformly covering no-route, inline, spawn, and already-
  routed modes (the RPC path's explicit emit is redundant but benign).

- Banner: corrected the Retry... (continued)

Coverage Stats

9101 of 12379 branches covered (73.52%)

Branch coverage included in aggregate %.

433 of 732 new or added lines in 13 files covered. (59.15%)

4 existing lines in 2 files now uncovered.

69047 of 78212 relevant lines covered (88.28%)

298.51 hits per line