• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

lsm / neokai / 24890604342
82%

Build:
DEFAULT BRANCH: dev
Ran 24 Apr 2026 12:56PM UTC
Jobs 34
Files 538
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

24 Apr 2026 12:55PM UTC coverage: 86.265% (-0.2%) from 86.484%
24890604342

push

github

web-flow
feat(space): runtime post-approval routing + mark_complete tool (PR 2/5) (#1621)

* feat(space): runtime post-approval routing + mark_complete tool (PR 2/5)

Runtime-driven post-approval routing gated behind
NEOKAI_TASK_AGENT_POST_APPROVAL_ROUTING (OFF by default). Introduces
PostApprovalRouter that, on approved transitions, either marks the task
done (no workflow post_approval), injects [POST_APPROVAL_INSTRUCTIONS]
into the Task Agent (targetAgent='task-agent'), or spawns a fresh
node-agent sub-session. Adds mark_complete MCP tool on the Task Agent
and mirrors it onto node-agent surfaces so post-approval executors can
finalize approved → done. Keeps approve_task semantics unchanged and
always emits [TASK_APPROVED] on approval. Wires UI surface for blocked
post-approval state via new InlineStatusBanner + PendingPostApprovalBanner.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* fix(space): forward approvalReason + emit on post-approval dispatch

Review fixes for PR 2/5:

- Bug 1: `SpaceRuntime.dispatchPostApproval` was dropping
  `contextExtras.approvalReason` on the review → approved transition,
  which then let `SpaceTaskManager.setTaskStatus` stamp `null` and
  overwrite whatever the RPC handler had just written. Forward the
  value explicitly, distinguishing missing (undefined) from explicit
  clear (null). Widens `setTaskStatus` options to accept `string | null`.

- Bug 2: The no-route branch inside `PostApprovalRouter.route` closes
  the task via `taskRepo.updateTask` directly, without emitting any
  notification. The RPC path re-reads + emits after dispatch, but the
  end-node tick path had no follow-up — UI stayed stuck at `approved`
  until the next poll. `dispatchPostApproval` now re-reads and calls
  `safeOnTaskUpdated` whenever the router returns a non-`skipped`
  result, uniformly covering no-route, inline, spawn, and already-
  routed modes (the RPC path's explicit emit is redundant but benign).

- Banner: corrected the Retry... (continued)

9101 of 12379 branches covered (73.52%)

Branch coverage included in aggregate %.

433 of 732 new or added lines in 13 files covered. (59.15%)

4 existing lines in 2 files now uncovered.

69047 of 78212 relevant lines covered (88.28%)

298.51 hits per line

Uncovered Changes

Lines Coverage ∆ File
190
83.59
-7.87% packages/daemon/src/lib/space/runtime/task-agent-manager.ts
43
54.24
-29.82% packages/daemon/src/lib/space/tools/end-node-handlers.ts
37
62.08
-5.95% packages/daemon/src/lib/rpc-handlers/space-task-handlers.ts
24
86.39
-5.14% packages/daemon/src/lib/space/runtime/space-runtime-service.ts
4
82.64
0.75% packages/daemon/src/lib/space/tools/task-agent-tools.ts
1
90.7
packages/web/src/components/space/PendingPostApprovalBanner.tsx

Coverage Regressions

Lines Coverage ∆ File
2
86.39
-5.14% packages/daemon/src/lib/space/runtime/space-runtime-service.ts
2
83.59
-7.87% packages/daemon/src/lib/space/runtime/task-agent-manager.ts
Jobs
ID Job ID Ran Files Coverage
1 daemon-0-shared - 24890604342.1 24 Apr 2026 12:56PM UTC 29
85.16
GitHub Action Run
2 daemon-5-space-workflow - 24890604342.2 24 Apr 2026 12:56PM UTC 81
33.61
GitHub Action Run
3 daemon-4-space-storage - 24890604342.3 24 Apr 2026 12:56PM UTC 117
50.38
GitHub Action Run
4 daemon-5-space-other - 24890604342.4 24 Apr 2026 12:56PM UTC 104
33.01
GitHub Action Run
5 daemon-5-space-agent - 24890604342.5 24 Apr 2026 12:56PM UTC 137
28.92
GitHub Action Run
6 daemon-online-cross-provider-4 - 24890604342.6 24 Apr 2026 12:56PM UTC 285
19.39
GitHub Action Run
7 daemon-online-websocket - 24890604342.7 24 Apr 2026 12:56PM UTC 285
15.28
GitHub Action Run
8 daemon-online-mcp - 24890604342.8 24 Apr 2026 12:56PM UTC 285
15.62
GitHub Action Run
9 daemon-online-git - 24890604342.9 24 Apr 2026 12:56PM UTC 285
17.99
GitHub Action Run
10 daemon-online-coordinator - 24890604342.10 24 Apr 2026 12:56PM UTC 285
6.3
GitHub Action Run
11 daemon-online-room-coder-subagents - 24890604342.11 24 Apr 2026 12:57PM UTC 285
17.75
GitHub Action Run
12 daemon-online-sdk - 24890604342.12 24 Apr 2026 12:56PM UTC 285
18.69
GitHub Action Run
13 daemon-online-rpc-1 - 24890604342.13 24 Apr 2026 12:56PM UTC 285
19.03
GitHub Action Run
14 daemon-online-space-2 - 24890604342.14 24 Apr 2026 12:58PM UTC 285
26.54
GitHub Action Run
15 daemon-online-features-2 - 24890604342.15 24 Apr 2026 12:56PM UTC 285
19.16
GitHub Action Run
16 daemon-online-cross-provider-2 - 24890604342.16 24 Apr 2026 12:56PM UTC 285
17.66
GitHub Action Run
17 daemon-online-room-mcp - 24890604342.17 24 Apr 2026 12:56PM UTC 285
17.48
GitHub Action Run
18 daemon-online-components - 24890604342.18 24 Apr 2026 12:56PM UTC 285
15.17
GitHub Action Run
19 daemon-online-rpc-3 - 24890604342.19 24 Apr 2026 12:56PM UTC 285
19.81
GitHub Action Run
20 daemon-online-features-1 - 24890604342.20 24 Apr 2026 12:56PM UTC 285
19.45
GitHub Action Run
21 daemon-online-rewind-1 - 24890604342.21 24 Apr 2026 12:57PM UTC 285
18.97
GitHub Action Run
22 daemon-online-convo - 24890604342.22 24 Apr 2026 12:57PM UTC 285
18.68
GitHub Action Run
23 daemon-online-features-3 - 24890604342.23 24 Apr 2026 12:56PM UTC 285
15.02
GitHub Action Run
24 daemon-5-space-runtime - 24890604342.24 24 Apr 2026 12:56PM UTC 101
44.63
GitHub Action Run
25 daemon-online-agent-sdk - 24890604342.25 24 Apr 2026 12:56PM UTC 285
18.77
GitHub Action Run
26 daemon-1-core - 24890604342.26 24 Apr 2026 12:56PM UTC 290
34.56
GitHub Action Run
27 daemon-online-cross-provider-3 - 24890604342.27 24 Apr 2026 12:56PM UTC 285
6.3
GitHub Action Run
28 daemon-online-rewind-2 - 24890604342.28 24 Apr 2026 12:57PM UTC 285
19.4
GitHub Action Run
29 daemon-online-space-1 - 24890604342.29 24 Apr 2026 12:57PM UTC 285
26.07
GitHub Action Run
30 web - 24890604342.30 24 Apr 2026 12:57PM UTC 242
78.64
GitHub Action Run
31 daemon-online-lifecycle - 24890604342.31 24 Apr 2026 12:56PM UTC 285
19.18
GitHub Action Run
32 daemon-online-rpc-2 - 24890604342.32 24 Apr 2026 12:57PM UTC 285
18.41
GitHub Action Run
33 daemon-online-rpc-4 - 24890604342.33 24 Apr 2026 12:57PM UTC 285
19.73
GitHub Action Run
34 daemon-2-handlers - 24890604342.34 24 Apr 2026 12:56PM UTC 234
50.93
GitHub Action Run
Source Files on build 24890604342
  • Tree
  • List 538
  • Changed 18
  • Source Changed 11
  • Coverage Changed 18
Coverage ∆ File Lines Relevant Covered Missed Hits/Line Branch Hits Branch Misses
  • Back to Repo
  • Github Actions Build #24890604342
  • b578aa21 on github
  • Prev Build on dev (#24874586600)
  • Next Build on dev (#24898893782)
  • Delete
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc