lsm / neokai / 24874586600

82%

push

github

feat(space): add 'approved' task status + workflow postApproval schema (PR 1/5) (#1620)

* feat(space): add 'approved' task status + workflow postApproval schema (PR 1/5)

Strictly additive, schema-only foundation for the task-agent-as-post-approval-
executor refactor. No runtime behaviour change — no edge produces the new
`approved` status yet, and no consumer reads `postApproval`. PR 2 wires the
router and `mark_complete` tool.

- Add `'approved'` to `SpaceTaskStatus` (between `review` and `done`).
- Add `PostApprovalRoute { targetAgent, instructions }` + optional
  `SpaceWorkflow.postApproval`.
- Add optional `postApprovalSessionId` / `postApprovalStartedAt` /
  `postApprovalBlockedReason` on `SpaceTask`.
- Migration 103: widen `space_tasks.status` CHECK (table-rebuild), add 3 new
  task columns, add `post_approval` JSON column on `space_workflows`.
- Repositories read/write the new columns.
- `SpaceWorkflowManager.create/update` validate `postApproval` against the
  workflow's node agents (+ `task-agent`). Stale routes are stripped at load
  time with a warn log.
- New `post-approval-template.ts`: single-pass `{{identifier}}` interpolator.
- Web `TaskStatusActions` + `SpaceTaskPane` label/transition maps extended to
  include `approved` so `Record<SpaceTaskStatus, ...>` typechecks. `review ->
  approved` is deliberately NOT added yet.

Plan doc: docs/plans/remove-completion-actions-task-agent-as-post-approval-executor.md

* docs(space): address review nits on PR 1/5

- Correct the fresh-DB guard comment in `runMigration103`: the early return
  only fires when M103 is invoked standalone before M29 has created
  `space_tasks` (tests/dev tooling). `createTables` does not create
  `space_tasks`; M29 does, and M103 rebuilds it with the widened CHECK.
- Note on `listActiveWithTaskAgentSession`: flag the PR 2 extension point
  (filter must widen to include `'approved'` once post-approval sessions are
  in-flight). Kept current filter to preserve PR 1's n... (continued)

9067 of 12336 branches covered (73.5%)

Branch coverage included in aggregate %.

252 of 254 new or added lines in 7 files covered. (99.21%)

68640 of 77515 relevant lines covered (88.55%)

299.99 hits per line