lsm / neokai / 24898893782

82%

push

github

feat(space): harden Reviewer preset agent prompt (#1622)

* feat(space): harden Reviewer preset agent prompt

Upgrade the Space Reviewer preset prompt in seed-agents.ts to match the
rigor of the Room SDK reviewer (buildSdkReviewerPrompt in leader-agent.ts).
The thin "review and post with gh pr review" instructions are replaced with
a structured procedure that mandates:

- Identity block at the top of every PR comment
- Sub-agent delegation (reviewer-explorer / reviewer-fact-checker via Task)
- Numbered review process with goal/completeness alignment
- Holistic review of full files and integration points, not just the diff
- P0–P3 severity classification — request changes if ANY finding exists
  (P3 included), approve only when completely clean
- Own-PR detection (gh api user vs PR author) with COMMENT fallback
- Over-engineering and omission checks
- Review URL capture via gh api ... --jq '.html_url' and structured
  ---REVIEW_POSTED--- output block so the URL is always visible to the
  caller

Tests updated to pin the new structure (identity, sub-agents, P0-P3
severity with decision rules, own-PR detection, URL capture, goal
alignment, omissions/over-engineering). The exact-string match is
replaced by a template-equality check so prose tweaks don't churn the
test file.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* fix(space): remove sub-agent delegation from Reviewer prompt

Review feedback caught that `reviewer-explorer` and `reviewer-fact-checker`
are defined only inside the Room SDK (`leader-agent.ts`) and are never
injected for Space sessions (`createCustomAgentInit` in custom-agent.ts
passes only the single custom agent). `REVIEWER_TOOLS` also omits
`Task`/`TaskOutput`/`TaskStop`, so the Reviewer could not spawn sub-agents
even if they were defined.

The delegation instructions were silently broken. Remove them and replace
with direct-exploration guidance (Read, Grep, Glob, WebSearch/WebFetch) —
the tools actually available on the ... (continued)

9101 of 12379 branches covered (73.52%)

Branch coverage included in aggregate %.

13 of 13 new or added lines in 1 file covered. (100.0%)

69054 of 78218 relevant lines covered (88.28%)

300.2 hits per line