lsm / neokai / 24804916750

83%

push

github

chore(web): remove global MCP Servers page + plan MCP unification (#1601)

* chore(web): remove global MCP Servers settings page + plan MCP unification

The "MCP Servers" settings page listed servers from project `.mcp.json` as
a global toggle — semantically confused now that sessions can exist without
a workspace. Application MCP Servers is the proper global path; per-session
project MCPs remain toggleable via the Tool Modal.

Also adds docs/plans/unify-mcp-config-model/00-overview.md proposing a
single-registry + single-override-table design that eliminates the six
overlapping MCP config sources responsible for ongoing bugs like `.mcp.json`
leaking into Space ad-hoc sessions.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* chore(web,e2e): fix review nits from #1601

Blocking E2E fixes:
- settings-modal.e2e.ts: drop 'Application MCP Servers' from expected nav
  sections (the button no longer renders)
- app-mcp-registry.e2e.ts: switch helper to exact getByRole match for the
  renamed 'MCP Servers' nav entry; update stale copy in description and
  test title

Non-blocking cleanups:
- ContextPanel.tsx: remove dead 'app-server' icon case (the nav entry now
  uses 'server')
- AppMcpServersSettings.tsx: rename panel heading + description from
  'Application MCP Servers' to 'MCP Servers' to match the nav label
- AddSkillDialog.tsx / EditSkillDialog.tsx: update stale "go to
  Application MCP Servers" copy to the new label

Plan doc clarifications (docs/plans/unify-mcp-config-model/00-overview.md):
- Spell out kill-switch semantics in M1: preserves pre-PR asymmetry, does
  not re-enable auto-load for coordinators
- Pin M2 dedupe key as (sourcePath, name); rename is remove+add
- Codify: .mcp.json scan never runs on session.create; only on workspace
  attach/change and explicit refresh

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* docs(mcp): polish M1 risk phrasing per review

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

--... (continued)

8971 of 12185 branches covered (73.62%)

Branch coverage included in aggregate %.

67266 of 76155 relevant lines covered (88.33%)

301.6 hits per line