lsm / neokai / 24801128055

83%

push

github

fix(space): preserve task-agent sdkSessionId across restart; eagerly spawn sub-sessions (#1599)

* fix(space): preserve task-agent sdkSessionId across restart and eagerly spawn sub-sessions

Root cause: task-agent and worker sub-sessions lost their captured sdkSessionId on
fingerprint mismatch (runtime re-init path in AgentSession.fromInit), forcing the
SDK to treat them as fresh sessions after a daemon restart. In addition, the
sub-session AgentSession objects were created lazily, so a daemon restart between
spawnTaskAgent and first user message left no in-memory trace of the workflow's
node agents — rehydration had nothing to hook into.

Changes:
- AgentSession.fromInit preserves sdkSessionId on fingerprint mismatch for
  space_task_agent sessions (and defensively for worker sessions with
  spaceId+taskId context, though workers currently skip the fingerprint branch).
- Add AgentSession.awaitSdkSessionCaptured(timeoutMs=15000) that polls via
  daemonHub 'session.updated' events with timeout — used by both spawn and
  eager paths to guarantee sdkSessionId is persisted before returning.
- SpaceWorktreeManager.getTaskWorktreePathSync(spaceId, taskId) reads from the
  space_worktrees SQLite table synchronously; the async variant delegates to it.
- TaskAgentManager.spawnTaskAgent now awaits sdkSessionCaptured on the task-agent
  itself, then calls eagerlySpawnWorkflowNodeAgents which creates one
  AgentSession per distinct workflow-node agent slot (first-occurrence wins for
  repeated slot names) and awaits their sdk-session capture too. No kickoff
  query is started on these eager sessions — they simply register so restart
  rehydration has live AgentSession hooks.
- TaskAgentManager.createSubSession reuses eager sub-sessions when the agent
  name matches, synthesizing a pseudo-NodeExecution for the eager fast path.
- TaskAgentManager.getTaskWorktreePath falls back to
  SpaceWorktreeManager.getTaskWorktreePathSync when the in-memory cache misses
  (e.g.... (continued)

8972 of 12186 branches covered (73.63%)

Branch coverage included in aggregate %.

242 of 247 new or added lines in 4 files covered. (97.98%)

67267 of 76156 relevant lines covered (88.33%)

301.6 hits per line