lsm / neokai / 24805423536

83%

Build Type

push

github

Committed by web-flow

Commit Message

fix(daemon): sessions only deleted/archived from UI (Task #85) (#1600)

* fix(daemon): sessions are only deleted/archived from UI (Task #85)

Restrict the two mutating session-resource primitives to UI-originated
paths and add a CI guard so they can't regress.

- SessionLifecycle/SessionManager: split the old `deleteSession` into
  `archiveResources` (keeps DB row + sdk_messages, cleans worktree + SDK)
  and `deleteResources` (full cascade). Lifecycle events can only call
  the new `interruptInMemorySession` which never touches DB or disk.
- session.archive RPC now delegates to `archiveSessionResources`;
  session.delete RPC calls `deleteSessionResources` with a
  `ui_session_delete` trigger. room.delete does the same for each child
  session via `ui_room_delete`.
- TaskAgentManager: `cleanup()` no longer deletes; task archive events
  drive `archiveSessionResources(..., 'ui_task_archive')`, which is the
  only path allowed to remove the space worktree.
- NeoAgentManager: `destroyAndRecreate()` now rehydrates from DB via
  `interruptInMemorySession` instead of recreating the row.
- scripts/check-session-deletion-callers.sh: allow-lists the legitimate
  callers of the UI-only primitives and the `ui_*` trigger identifiers;
  wired into `bun run check`.

Adds/updates unit tests across session-lifecycle, session-manager,
session-handlers, room-handlers, neo-agent-manager, and task-agent-*
suites to assert the preserve-DB invariant on every non-UI cleanup.

* fix(daemon): clear session.worktree + snapshot response fields during archive

- `archiveResources` now passes `worktree: undefined` to `update()` when the
  session had a worktree, so the DB row's worktree_* columns are cleared
  alongside the on-disk worktree removal. Matches the pre-Task-#85
  behaviour and keeps `session.worktree` from pointing at a deleted path.
- `session.archive` RPC snapshots `hadWorktree` + `roomIdForArchive` before
  calling `archiveSessionResources`. The `session` value ret... (continued)

Coverage Stats

8971 of 12185 branches covered (73.62%)

Branch coverage included in aggregate %.

239 of 247 new or added lines in 10 files covered. (96.76%)

1 existing line in 1 file now uncovered.

67388 of 76181 relevant lines covered (88.46%)

302.54 hits per line