• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

lsm / neokai / 24805423536
83%

Build:
DEFAULT BRANCH: dev
Ran 22 Apr 2026 10:14PM UTC
Jobs 34
Files 525
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

22 Apr 2026 10:13PM UTC coverage: 86.412% (+0.1%) from 86.3%
24805423536

push

github

web-flow
fix(daemon): sessions only deleted/archived from UI (Task #85) (#1600)

* fix(daemon): sessions are only deleted/archived from UI (Task #85)

Restrict the two mutating session-resource primitives to UI-originated
paths and add a CI guard so they can't regress.

- SessionLifecycle/SessionManager: split the old `deleteSession` into
  `archiveResources` (keeps DB row + sdk_messages, cleans worktree + SDK)
  and `deleteResources` (full cascade). Lifecycle events can only call
  the new `interruptInMemorySession` which never touches DB or disk.
- session.archive RPC now delegates to `archiveSessionResources`;
  session.delete RPC calls `deleteSessionResources` with a
  `ui_session_delete` trigger. room.delete does the same for each child
  session via `ui_room_delete`.
- TaskAgentManager: `cleanup()` no longer deletes; task archive events
  drive `archiveSessionResources(..., 'ui_task_archive')`, which is the
  only path allowed to remove the space worktree.
- NeoAgentManager: `destroyAndRecreate()` now rehydrates from DB via
  `interruptInMemorySession` instead of recreating the row.
- scripts/check-session-deletion-callers.sh: allow-lists the legitimate
  callers of the UI-only primitives and the `ui_*` trigger identifiers;
  wired into `bun run check`.

Adds/updates unit tests across session-lifecycle, session-manager,
session-handlers, room-handlers, neo-agent-manager, and task-agent-*
suites to assert the preserve-DB invariant on every non-UI cleanup.

* fix(daemon): clear session.worktree + snapshot response fields during archive

- `archiveResources` now passes `worktree: undefined` to `update()` when the
  session had a worktree, so the DB row's worktree_* columns are cleared
  alongside the on-disk worktree removal. Matches the pre-Task-#85
  behaviour and keeps `session.worktree` from pointing at a deleted path.
- `session.archive` RPC snapshots `hadWorktree` + `roomIdForArchive` before
  calling `archiveSessionResources`. The `session` value ret... (continued)

8971 of 12185 branches covered (73.62%)

Branch coverage included in aggregate %.

239 of 247 new or added lines in 10 files covered. (96.76%)

1 existing line in 1 file now uncovered.

67388 of 76181 relevant lines covered (88.46%)

302.54 hits per line

Uncovered Changes

Lines Coverage ∆ File
4
71.62
-0.24% packages/daemon/src/lib/rpc-handlers/room-handlers.ts
3
90.98
-0.01% packages/daemon/src/lib/space/runtime/task-agent-manager.ts
1
82.76
-0.13% packages/daemon/src/lib/rpc-handlers/index.ts

Coverage Regressions

Lines Coverage ∆ File
1
71.66
-1.45% packages/daemon/src/lib/rpc-handlers/session-handlers.ts
Jobs
ID Job ID Ran Files Coverage
1 daemon-5-space-agent - 24805423536.1 22 Apr 2026 10:14PM UTC 133
28.71
GitHub Action Run
2 daemon-online-room-mcp - 24805423536.2 22 Apr 2026 10:14PM UTC 277
17.75
GitHub Action Run
3 daemon-online-convo - 24805423536.3 22 Apr 2026 10:15PM UTC 277
19.02
GitHub Action Run
4 daemon-4-space-storage - 24805423536.4 22 Apr 2026 10:15PM UTC 115
49.53
GitHub Action Run
5 daemon-online-lifecycle - 24805423536.5 22 Apr 2026 10:15PM UTC 277
19.55
GitHub Action Run
6 daemon-online-cross-provider-3 - 24805423536.6 22 Apr 2026 10:14PM UTC 277
6.38
GitHub Action Run
7 daemon-0-shared - 24805423536.7 22 Apr 2026 10:14PM UTC 29
85.16
GitHub Action Run
8 daemon-online-websocket - 24805423536.8 22 Apr 2026 10:14PM UTC 277
15.51
GitHub Action Run
9 daemon-online-agent-sdk - 24805423536.9 22 Apr 2026 10:15PM UTC 277
19.12
GitHub Action Run
10 daemon-online-sdk - 24805423536.10 22 Apr 2026 10:15PM UTC 277
19.03
GitHub Action Run
11 daemon-online-git - 24805423536.11 22 Apr 2026 10:15PM UTC 277
18.3
GitHub Action Run
12 daemon-online-features-1 - 24805423536.12 22 Apr 2026 10:15PM UTC 277
19.82
GitHub Action Run
13 daemon-online-components - 24805423536.13 22 Apr 2026 10:14PM UTC 277
15.39
GitHub Action Run
14 web - 24805423536.14 22 Apr 2026 10:15PM UTC 237
78.7
GitHub Action Run
15 daemon-online-rpc-2 - 24805423536.15 22 Apr 2026 10:15PM UTC 277
18.85
GitHub Action Run
16 daemon-5-space-other - 24805423536.16 22 Apr 2026 10:14PM UTC 101
33.4
GitHub Action Run
17 daemon-online-mcp - 24805423536.17 22 Apr 2026 10:14PM UTC 277
16.31
GitHub Action Run
18 daemon-online-coordinator - 24805423536.18 22 Apr 2026 10:14PM UTC 277
6.39
GitHub Action Run
19 daemon-online-cross-provider-2 - 24805423536.19 22 Apr 2026 10:14PM UTC 277
17.97
GitHub Action Run
20 daemon-online-cross-provider-4 - 24805423536.20 22 Apr 2026 10:15PM UTC 277
19.76
GitHub Action Run
21 daemon-online-rpc-4 - 24805423536.21 22 Apr 2026 10:15PM UTC 277
20.11
GitHub Action Run
22 daemon-online-space-1 - 24805423536.22 22 Apr 2026 10:15PM UTC 277
26.33
GitHub Action Run
23 daemon-online-rpc-1 - 24805423536.23 22 Apr 2026 10:15PM UTC 277
19.34
GitHub Action Run
24 daemon-online-features-3 - 24805423536.24 22 Apr 2026 10:14PM UTC 277
15.05
GitHub Action Run
25 daemon-2-handlers - 24805423536.25 22 Apr 2026 10:14PM UTC 225
50.15
GitHub Action Run
26 daemon-1-core - 24805423536.26 22 Apr 2026 10:15PM UTC 282
34.88
GitHub Action Run
27 daemon-online-rewind-2 - 24805423536.27 22 Apr 2026 10:15PM UTC 277
19.77
GitHub Action Run
28 daemon-online-room-coder-subagents - 24805423536.28 22 Apr 2026 10:14PM UTC 277
18.02
GitHub Action Run
29 daemon-online-rpc-3 - 24805423536.29 22 Apr 2026 10:15PM UTC 277
20.38
GitHub Action Run
30 daemon-online-rewind-1 - 24805423536.30 22 Apr 2026 10:15PM UTC 277
19.33
GitHub Action Run
31 daemon-5-space-runtime - 24805423536.31 22 Apr 2026 10:14PM UTC 98
43.38
GitHub Action Run
32 daemon-online-features-2 - 24805423536.32 22 Apr 2026 10:15PM UTC 277
19.53
GitHub Action Run
33 daemon-online-space-2 - 24805423536.33 22 Apr 2026 10:16PM UTC 277
26.88
GitHub Action Run
34 daemon-5-space-workflow - 24805423536.34 22 Apr 2026 10:14PM UTC 78
33.26
GitHub Action Run
Source Files on build 24805423536
  • Tree
  • List 525
  • Changed 27
  • Source Changed 12
  • Coverage Changed 27
Coverage ∆ File Lines Relevant Covered Missed Hits/Line Branch Hits Branch Misses
  • Back to Repo
  • Github Actions Build #24805423536
  • 92d9e0aa on github
  • Prev Build on dev (#24804916750)
  • Next Build on dev (#24805936249)
  • Delete
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc