Freegle / Iznik / 5281

70%

push

circleci

fix(sentry): guard Array.filter against undefined items accessing .error (NUXT3-D45) (#217)

* feat(donations): default target 5000; allow DONATION_TARGET/DONATIONS_EXCLUDE via .env

Wire DONATION_TARGET and DONATIONS_EXCLUDE through docker-compose into the
apiv2 / apiv2-live containers so they can be overridden from .env (.env.example
now has a commented example). Default target bumped 2000 → 5000.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* fix(sentry): guard Array.filter against undefined items accessing .error (NUXT3-D45)

TypeError "Cannot read properties of undefined (reading 'error')" — 47
events / 32 users since 2026-03-30 — fires from an unhandled promise
rejection inside @uppy/core/lib/Uppy.js #runUpload:

    const files = currentUpload.fileIDs.map((fileID) => this.getFile(fileID))
    const successful = files.filter((file) => !file.error)
    const failed = files.filter((file) => file.error)

When a file is removed mid-upload (user clicks "Remove photo" during a
retry cycle) its entry disappears from state.files but its ID is still
in currentUpload.fileIDs. getFile returns undefined for the stale ID,
and the partition filters blow up reading .error.

Stack trace (Sentry event 7375216978):
  {_Uppy#2}.retryAll → runUpload_fn → Array.filter(<anonymous>) → successful

URL: /give/mobile/photos. Breadcrumbs confirm the sequence: multiple
uploads fail with "network error" → user clicks "Remove photo" → retry
tick partitions a fileIDs list that now contains a deleted file.

The sibling patch (NUXT3-D2C) guards @uppy/utils fileFilters for the
same "undefined file in the array" shape; this patch does the same for
the two inline filters in #runUpload.

Fix via patch-package:
  patches/@uppy+core+4.5.3.patch — `file != null` guard in both callbacks
  (both Uppy.js and Uppy.ts so the patch stays consistent across rebuilds).

Adds tests/unit/patches/uppy-core-runUpload.spec.js — reads the patched
Uppy.js and asserts the guarded callback... (continued)

13321 of 20370 branches covered (65.4%)

Branch coverage included in aggregate %.

95949 of 132263 relevant lines covered (72.54%)

21.65 hits per line