Freegle / Iznik / 5251

70%

Build Type

push

circleci

Committed by web-flow

Commit Message

fix(ads): allow clicks on Jobs and static ads once ad renders (#222)

Commit ba725baeb switched ExternalDa.vue's `passClicks` from a boolean
(silently-invalid CSS that always fell back to `auto`) to concrete
`'none'`/`'auto'` values but kept the same ternary direction, which
inverted the effective behaviour: once an ad/fallback resolved
(`adShown=true`), the container got `pointer-events: none` and blocked
clicks on Jobs links and static banner ads (Utility Warehouse, Temu,
etc.). Video ads were unaffected because they float above the container.

Flip the mapping so the rendered ad or fallback slot is clickable and
the empty placeholder is click-transparent, and update the existing
tests to codify the corrected contract.

Reported on Discourse #9481 posts 492/493.

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>

Coverage Stats

13422 of 20540 branches covered (65.35%)

Branch coverage included in aggregate %.

6 of 6 new or added lines in 1 file covered. (100.0%)

89 existing lines in 10 files now uncovered.

95973 of 132309 relevant lines covered (72.54%)

21.76 hits per line