Freegle / Iznik / 5311

70%

push

circleci

test(coverage): vectorsearch — body-tier, tier ordering, threshold drops, blur (#227)

Add seven deterministic tests for message.VectorSearch that exercise branches
and invariants not covered by the existing suite:

- TestVectorSearchBodyTierWhenSubjectBelowThreshold: covers
  `else if vr.HasBody && vr.BodyCos >= MinVectorScore`. Every existing test
  has SubjectCos >= threshold, so the body-tier append path never ran.
- TestVectorSearchSubjectTierComesBeforeBodyTier: pins the tier invariant
  that `combined := append(subjectTier, bodyTier...)` keeps subject-tier
  results ahead of body-tier ones even when the body-tier entry has a
  higher raw score (via keyword boost).
- TestVectorSearchCombinedTruncationAcrossTiers: covers `len(combined) > limit`
  truncation when the cut line falls between the two tiers (existing limit
  test only truncates within a single all-subject-tier result set).
- TestVectorSearchDropsResultsBelowBothThresholds: covers the implicit
  "neither branch taken" path — entries with both cosines below
  MinVectorScore must be dropped rather than silently returned.
- TestVectorSearchStopWordQuerySkipsKeywordBoost: covers the false leg of
  `if len(queryWords) > 0` by passing an all-stop-word query ("the and or"),
  so GetWords returns empty and the keyword-boost block is skipped.
- TestVectorSearchBlursReturnedCoordinates: pins the privacy invariant that
  SearchResult.Lat/Lng are blurred via utils.Blur before leaving the API.
- TestVectorSearchHasBodyFalseDoesNotEnterBodyTier: covers the short-circuit
  on the body-tier condition — HasBody=false must prevent entry regardless
  of BodyCos.

Uses a local Gram-Schmidt helper (makeOrthogonalTestVec) because makeTestVec
seeds produce nearly collinear vectors and can't drive cosines below the 0.65
threshold. Mirrors the helper already used in embedding/store_test.go.

Tests: 1790/1790 Go pass.

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>

8865 of 10243 branches covered (86.55%)

Branch coverage included in aggregate %.

62362 of 127270 relevant lines covered (49.0%)

9.67 hits per line