kobotoolbox / kpi / 22175072348

82%

master: 76%

push

github

refactor(translationSettings): stop using `allAssets` DEV-1331 (#6723)

### 💭 Notes

`TranslationSettings` is a component that is being rendered inside a
modal. It was operating on two options - either you pass `asset:
AssetResponse` or pass `assetUid: string`. In first case it is
straightforward use of asset object data. In second case component is
fetching asset data using the `assetUid` given (this is the moment
`allAssets.whenLoaded` is being used.

I discovered that all the places that use the modal pass asset object.
One of the places was passing `asset.uid` and triggering
`allAssets.whenLoaded`. I changed it to pass `asset` and thus making the
`assetUid: string` option obsolete.

### 👀 Preview steps

1. ℹ️ Have an account and a project with question that has both label
and hint
2. Go to Project → FORM
3. Click on "Manage translations" button (the globe under "(RE)DEPLOY"
button)
4. 🟢 In the modal be sure to test out these functionalities:
   1. Adding another language ("Add language" button)
2. Changing the default language ("Make default" button - a globe with
star icon next to language name)
   3. Edit language name and code ("Edit language" icon button - pencil)
   4. Delete language ("Delete language" icon button - trash can)
5. Navigating to "Update translations" modal and back ("Update
translations" icon button - globe with cog icon) should work (the
contents of "Update translations" modal are separate component, no need
to be tested here)

---------

Co-authored-by: Paulo Amorim <pauloamorimbr@gmail.com>
Co-authored-by: Akuukis <Akuukis@users.noreply.github.com>

7441 of 11473 branches covered (64.86%)

28544 of 34796 relevant lines covered (82.03%)

1.62 hits per line