kobotoolbox / kpi / 22179935469

82%

master: 76%

push

github

refactor(translationSettings): tsify DEV-1332 (#6728)

### 💭 Notes

Context: I was in the middle of migrating to TS in preparation of
DEV-1331 (migrating from `allAssets` to react-query), but then realised
I can remove `allAsset` altogether. I made a PR for that #6723 and then
got back to TS migration here.

Changes here:
- migrating `translationSettings.js` to TS
- adjusting few types in `dataInterface` to match the TS code
  - cleared out one TODO
- had to adjust types in multiple places (allowing `Array<string |
null>` where places expected this to be always `Array<string>`)
- fixed a typo in actions types (`onFail` callback should've been
`onFailed`)

### 👀 Preview steps

Same as in #6723

1. ℹ️ Have an account and a project with question that has both label
and hint
2. Go to Project → FORM
3. Click on "Manage translations" button (the globe under "(RE)DEPLOY"
button)
4. 🟢 In the modal be sure to test out these functionalities:
   1. Adding another language ("Add language" button)
2. Changing the default language ("Make default" button - a globe with
star icon next to language name)
   3. Edit language name and code ("Edit language" icon button - pencil)
   4. Delete language ("Delete language" icon button - trash can)
5. Navigating to "Update translations" modal and back ("Update
translations" icon button - globe with cog icon) should work (the
contents of "Update translations" modal are separate component, no need
to be tested here)

---------

Co-authored-by: Paulo Amorim <pauloamorimbr@gmail.com>
Co-authored-by: Akuukis <Akuukis@users.noreply.github.com>

7441 of 11473 branches covered (64.86%)

28544 of 34796 relevant lines covered (82.03%)

1.62 hits per line