kobotoolbox / kpi / 22175029632

82%

master: 76%

push

github

refactor(reports): stop using `allAssets` DEV-1335 (#6722)

### 💭 Notes

The main goal is to remove `allAssets`, so I didn't refactor too much.

Notable changes:
- Using `useAssetsRetrieve` instead of `allAssets.whenLoaded`
- `loadReportData` doesn't do two calls anymore (used to do
`allAssets.whenLoaded` and after success in a callback
`dataInterface.getReportData`), now it only fetches report data
- Instead of `allAssets.whenLoaded` it now is being triggered by
`useEffect` with `[assetQuery.data?.data]`
- Adjusted few comments

### 👀 Preview steps

Basically same as #6721 so:

1. ℹ️ Have an account and a project (e.g. Pizza from
[kobo-fixture](https://github.com/kobotoolbox/kobo-fixture)) with
submissions
2. Go to Project → Data → Reports
3. 🟢 Notice that reports still loads correctly (i.e. no UI crash, not
missing data)
4. 🟢 Make sure the following still works:
1. "Create New Report" flow (blue "+" button near the top of the
section)
   2. "Configure Report Style" flow (navy cog button)
   3. "Toggle fullscreen" functionality (top right corner - icon button)
   4. "Override graph style" flow ("…" button in top right of a report)

---------

Co-authored-by: Paulo Amorim <pauloamorimbr@gmail.com>
Co-authored-by: Akuukis <Akuukis@users.noreply.github.com>

7441 of 11473 branches covered (64.86%)

28544 of 34796 relevant lines covered (82.03%)

1.62 hits per line