lsm / neokai / 21852593468

39%

push

github

refactor(e2e): remove direct API calls, enforce pure browser testing

E2E tests should simulate real user interactions through Playwright,
not bypass the UI with direct RPC/event/state calls.

- Add E2E test rules to CLAUDE.md (prohibited patterns, allowed exceptions)
- Delete global-settings.e2e.ts (pure RPC, zero UI — belongs in daemon tests)
- Delete safari-background-tab.e2e.ts (RPC session creation, fake visibility events)
- Delete database-integrity.e2e.ts.disabled (dead code)
- Rewrite connection-resilience.e2e.ts: page.context().setOffline() instead of
  connectionManager.simulateDisconnect(), remove message injection tests
- Rewrite error-scenarios.e2e.ts: remove direct state mutation and RPC tests
- Rewrite auth-error-scenarios.e2e.ts: remove hub.event() injection tests
- Clean up wait-helpers.ts: remove unused functions, simplify setupMessageHubTesting
- Clean up slash-command-helpers.ts: DOM-based slash command detection
- Clean up global.d.ts: remove unused Window augmentation properties

2203 of 2312 branches covered (95.29%)

Branch coverage included in aggregate %.

14470 of 15244 relevant lines covered (94.92%)

350.84 hits per line