lsm / neokai / 21870817816

39%

push

github

fix(e2e): use WebSocket close instead of setOffline for disconnection tests

page.context().setOffline() blocks new HTTP requests but does NOT close
existing WebSocket connections. WebSockets are persistent connections that
remain open until explicitly closed or timeout.

This caused E2E tests to fail because they expected Offline UI indicator
to appear immediately after setOffline(), but the WebSocket never closed.

Solution:
- Created closeWebSocket() helper that calls ws.close() via page.evaluate()
- Triggers real WebSocket onclose event, properly updating connection state
- Updated all connection/reconnection tests to use new helpers
- Updated CLAUDE.md E2E rules to clarify proper disconnection testing

Tests affected:
- connection-resilience.e2e.ts (8 setOffline calls replaced)
- error-scenarios.e2e.ts (3 setOffline calls replaced)
- interruption-helpers.ts (updated to use new helpers)

2203 of 2312 branches covered (95.29%)

Branch coverage included in aggregate %.

14470 of 15244 relevant lines covered (94.92%)

350.84 hits per line