agama-project / agama / 16289491869

74%

push

github

fix(web): improve UX around non-persistent connections (#2555)

As per feedback received in bug report
https://bugzilla.suse.com/show_bug.cgi?id=1245187 (protected link) ,
this PR aims to polish the user experience when dealing with
non-persistent network connections during installation setup:

* Adjusted alert severity
The alert about no persistent connections is now rendered using the
custom variant instead of warning. This change reflects its non-blocking
nature and avoids confusing users by presenting it with the same
prominence as critical issues.

* Renders such an alert in the connection details page too
When toggling a connection to "installation-only" results in no
connections being persisted, the alert is now shown directly in the
connection details page. This provides immediate feedback about the side
effect, helping users avoid unintentionally ending up with no configured
network after installation, especially since this information is not
displayed elsewhere.

The second change is somewhat controversial, as **somehow it goes in a
different direction from the first, alerting users too early about a
non-critical issue**. While it does help prevent users from
unintentionally misconfiguring their system, ideally this kind of
feedback should be shown later in the flow, such as in the issues drawer
close to the critical ones or in the confirmation dialog, the only point
where Agama can be certain the user has finished setting up the
installation. This would help avoid interrupting the setup experience
while ensuring users has all needed information before proceed with
installation. However, due to current limitations in the confirmation
dialog and the absent of feedback for non-critical issues, this change
serves as a **reasonable temporary mitigation** to prevent users from
overlooking a side effect introduced by a recently added feature.

1949 of 3587 branches covered (54.34%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

24008 of 36922 relevant lines covered (65.02%)

47.7 hits per line