agama-project / agama / 16289609863

74%

push

github

nm/dbus: fix autoconnect of port devices (#2492)

## Problem

* A port device should also inherit the `autoconnect` from it's
corresponding agama connection, otherwise it happen that the interface
isn't added as port to the controller.
* This happen, because we always (which I think is correct) add/modify
the controller connection first (see:
[rust/agama-network/src/nm/adapter.rs#L187](https://github.com/cfconrad/agama//blob/9404de422/rust/agama-network/src/nm/adapter.rs#L187)
)
* Later if we add a port, the `autoconnect-ports=1` isn't triggered
anymore.
* The (from my point of view) faulty behavior was introduced here
https://github.com/agama-project/agama/commit/61cffffce

Faulty example (this is how it looks like, if we keep the force of
`autoconnect=false` for the port device):
```bash
$ bridge=br1
$ port=en0
$ nmcli connection add type bridge con-name $bridge ifname $bridge \
      ipv4.method manual ipv4.addresses 192.0.2.1/24  \
      connection.autoconnect 1 connection.autoconnect-ports 1
Connection 'br1' (80038fbc-ed60-41e3-b994-9cbaa9d258a2) successfully added.
$ nmcli connection add type ethernet con-name en0 port-type bridge controller $bridge \
      connection.autoconnect 0
Connection 'en0' (324617a8-70cb-43e7-b121-64306229d3dc) successfully added.
$ brctl show
bridge name     bridge id               STP enabled     interfaces
br1             8000.c6c15414602b       yes
```

Compared to (where brctl show the interface as port):
```
$ bridge=br1
$ port=en0
$ nmcli connection add type bridge con-name $bridge ifname $bridge \
      ipv4.method manual ipv4.addresses 192.0.2.1/24 \
      connection.autoconnect 1 connection.autoconnect-ports 1
Connection 'br1' (e83dbff7-d67e-4d08-b799-cf320f46719e) successfully added.
$ nmcli connection add type ethernet con-name $port ifname $port port-type bridge controller $bridge \
      connection.autoconnect 1
Connection 'en0' (6173b81e-3eb0-4... (continued)

1949 of 3587 branches covered (54.34%)

Branch coverage included in aggregate %.

22084 of 28088 relevant lines covered (78.62%)

62.62 hits per line