agama-project / agama / 16266089882

74%

Build Type

push

github

Committed by web-flow

Commit Message

Use the DUD repository for installing packages (#2543)

## Problem

- The DUD repository is not used for installing packages into the target
system

## Solution

- Add the local DUD repository into the list of used repositories, use a
higher priority so the provided packages are preferred (even when they
have a lower version than in the other repositories).
- Added `inst.dud_packages.gpg=0` boot option for ignoring GPG problems
with the DUD packages (the other packages are still checked as usually).

## Notes

- Libzypp supports "plaindir" repository type, that is basically a local
directory with RPM files without any metadata. When no metadata is found
in a `dir:/` repository then libzypp automatically switches to the
"plaindir" type and scans the available RPMs there.
- That is easier to handle (no need to create metadata) and it saves
some RAMdisk space (not creating the metadata files). The most important
feature is that the "plaindir" repositories are by definition not GPG
signed so libzypp does not complain about using an unsigned repository.
- So we can remove the `createrepo_c` package from the Live medium and
do not call it.

## Other fixes or improvements

- Fixed parsing the boot options (originally using `inst.foo=x` and
`inst.foo.bar=x` together crashed the installer)
- Deleted the old DUD script (the initial PoC)
- Automatically configure network by dracut when a remote DUD is used
(no need for the explicit `rd.neednet=1` boot option)

## Testing

- Tested manually with a DUD with trivial
[hello-world](https://build.opensuse.org/package/show/home:lslezak:dud-test2/hello-world)
package
- Note: The testing package uses the `Supplements: aaa_base` dependency
to select the package to install, otherwise the package would need to be
selected to install by using CLI.

## Screenshots

The testing package is signed by an unknown GPG key, an error is
reported during installation. When using the `inst.dud_packages.gpg=0`
boot option the error is no... (continued)

Run Details

1947 of 3587 branches covered (54.28%)

Branch coverage included in aggregate %.

73 of 77 new or added lines in 7 files covered. (94.81%)

1 existing line in 1 file now uncovered.

23988 of 36920 relevant lines covered (64.97%)

47.55 hits per line