agama-project / agama / 12870685697

74%

Build Type

push

github

Committed by web-flow

Commit Message

feat: ask for license acceptance (#1922)

## Problem

Agama does not show the license of any product and does not ask the user
to accept it. This is a requirement for beta 1, and it needs to be
implemented as soon as possible.

## Solution

Extend Agama to allow the specification of a license per product. The
license should be accepted on the product selection page. The solution
does not cover all cases (e.g., openSUSE licenses are not there yet) and
the technical details might change soon. But it is expected to be good
enough for beta 1.

The licenses are included in `/usr/share/agama/eula` with one directory
per license. The directory name is used as the license ID
(`license.beta` and `license.final`) and it contains the translations.

## Licenses

The licenses come from the
https://build.suse.de/package/show/SUSE:SLE-15-SP7:GA/skelcd package.

## Testing

- Added a new unit test
- Tested manually

## Screenshots

<details>
<summary>Click to show/hide some screenshots</summary>

---

**Be aware below screenshots were taken using mock data for emulating a
license in a product and illustrating the new interface controls and
behavior.**


| Product without license | Product with license |
|-|-|
|![Product without
license](https://github.com/user-attachments/assets/ee80b708-158d-4094-88df-afc2138c4744)
|![Product with
license](https://github.com/user-attachments/assets/2afb88c7-9494-425b-b471-fdd95e852b27)
|

| License accepted for a product not selected yet | License accepted for
a product previously selected |
|-|-|
| ![License accepted for a product not selected
yet](https://github.com/user-attachments/assets/320d83f0-b285-4068-b19b-d12f455d2c0a)
| ![License accepted for a product previously
selected](https://github.com/user-attachments/assets/3d530ea8-3ca8-49c8-99cc-0daa69481cd2)

|License dialog |
|-|
|![License
dialog](https://github.com/user-attachments/assets/2e0c27b3-bb1f-4479-a957-5bf7bf35b5b1)
|

</details>

Run Details

58 of 91 new or added lines in 7 files covered. (63.74%)

25 existing lines in 5 files now uncovered.

17233 of 24300 relevant lines covered (70.92%)

35.51 hits per line