agama-project / agama / 12872723315

74%

Build Type

push

github

Committed by web-flow

Commit Message

feat(software): Reload repositories after failure (#1894)

## Problem


![agama-repo-failed](https://github.com/user-attachments/assets/522bb11c-9698-4278-816e-b472f25d73f1)


- When repository refresh fails there is no way how to retry the
operation
- The only workaround is to select a different product and then select
back the original product
- This obviously won't work if the installer contains only one product

## Solution

- Detect that a repository failed and offer a reload action

## Recording

<!--
[SLES4SAP-screen0.webm](https://github.com/user-attachments/assets/cd530256-c553-400a-b794-f628b06b3980)
-->

[SLES4SAP-screen0.webm](https://github.com/user-attachments/assets/ad9a5798-5f42-4333-8a4a-9419953a85ee)


- There is a new error section with "retry" link
- Unfortunately the VirtualBox does not record the mouse pointer so it
not obvious that the "Try again" link was clicked by mouse
- For easier testing I used a local copy of the SLE repository to easily
simulate unreachable repository and make it working for the retry
attempt. That's why you see a different (local) repository in the
recording.


## Details

- It turned out that it is not simple to detect a repository failure in
the software page.
- It reports an issue but it might contain a translated text or there
might be a different issue like missing product or pattern. That means
we cannot use the issues texts.
- We will very likely need a repository management later anyway it makes
sense to add API for fetching the current repository setup with the load
status (succeeded or failed).

## Tasks

- [x] DBus interface for listing the current repository setup (added the
`ListRepositories` DBus method)
- [x] Add the HTTP API endpoint `/api/software/repositories` using the
DBus backend above (@jreidinger thanks!)
- [x] Adapt the frontend code to show a failure
- [x] Adapt the frontend to retry after clicking a button

---------

Co-authored-by: Josef Reidinger <jreidinger@suse.cz>

Run Details

4 of 28 new or added lines in 6 files covered. (14.29%)

86 existing lines in 5 files now uncovered.

17241 of 24316 relevant lines covered (70.9%)

35.49 hits per line