• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

agama-project / agama / 12870685737
74%

Build:
DEFAULT BRANCH: master
Ran 20 Jan 2025 03:01PM UTC
Jobs 2
Files 647
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

20 Jan 2025 02:58PM UTC coverage: 70.966% (+0.005%) from 70.961%
12870685737

push

github

web-flow
feat: ask for license acceptance (#1922)

## Problem

Agama does not show the license of any product and does not ask the user
to accept it. This is a requirement for beta 1, and it needs to be
implemented as soon as possible.

## Solution

Extend Agama to allow the specification of a license per product. The
license should be accepted on the product selection page. The solution
does not cover all cases (e.g., openSUSE licenses are not there yet) and
the technical details might change soon. But it is expected to be good
enough for beta 1.

The licenses are included in `/usr/share/agama/eula` with one directory
per license. The directory name is used as the license ID
(`license.beta` and `license.final`) and it contains the translations.

## Licenses

The licenses come from the
https://build.suse.de/package/show/SUSE:SLE-15-SP7:GA/skelcd package.

## Testing

- Added a new unit test
- Tested manually

## Screenshots

<details>
<summary>Click to show/hide some screenshots</summary>

---

**Be aware below screenshots were taken using mock data for emulating a
license in a product and illustrating the new interface controls and
behavior.**


| Product without license | Product with license |
|-|-|
|![Product without
license](https://github.com/user-attachments/assets/ee80b708-158d-4094-88df-afc2138c4744)
|![Product with
license](https://github.com/user-attachments/assets/2afb88c7-9494-425b-b471-fdd95e852b27)
|

| License accepted for a product not selected yet | License accepted for
a product previously selected |
|-|-|
| ![License accepted for a product not selected
yet](https://github.com/user-attachments/assets/320d83f0-b285-4068-b19b-d12f455d2c0a)
| ![License accepted for a product previously
selected](https://github.com/user-attachments/assets/3d530ea8-3ca8-49c8-99cc-0daa69481cd2)

|License dialog |
|-|
|![License
dialog](https://github.com/user-attachments/assets/2e0c27b3-bb1f-4479-a957-5bf7bf35b5b1)
|

</details>

8 of 21 new or added lines in 6 files covered. (38.1%)

124 existing lines in 6 files now uncovered.

17188 of 24220 relevant lines covered (70.97%)

35.62 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
2
0.0
0.0% rust/agama-lib/src/product/client.rs
2
84.26
-1.59% service/lib/agama/dbus/software/product.rb
9
0.0
0.0% rust/agama-server/src/software/web.rs

Uncovered Existing Lines

Lines Coverage ∆ File
1
96.0
0.08% service/service/lib/agama/software/product_builder.rb
1
97.62
0.12% service/service/lib/agama/software/product.rb
9
74.58
0.34% service/service/lib/agama/software/manager.rb
11
84.26
-1.59% service/service/lib/agama/dbus/software/product.rb
25
0.0
0.0% rust/agama-lib/src/product/client.rs
77
0.0
0.0% rust/agama-server/src/software/web.rs
Subprojects
ID Flag name Job ID Ran Files Coverage
2 service 12870685737.2 20 Jan 2025 03:01PM UTC 518
89.14
GitHub Action Run
2 rust 12810406017.2 16 Jan 2025 02:08PM UTC 129
24.85
GitHub Action Run
Source Files on build 12870685737
  • Tree
  • List 647
  • Changed 8
  • Source Changed 4
  • Coverage Changed 8
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #12870685737
  • 31823f4a on github
  • Prev Build on master (#12867480174)
  • Next Build on master (#12870685697)
  • Delete
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc