agama-project / agama / 11840609705

68%

Build Type

push

github

Committed by web-flow

Commit Message

AgamaProposal: fix bug when partitions are searched but not managed (#1767)

## Problem

When a drive was configured with an empty search for partitions like
this (in which there is no configuration about deleting or resizing the
found partitions)...

```json
{
  "storage": {
    "drives": [
      {
        "partitions": [
          { "search": "*" },
          { "filesystem": { "path": "/" } }
        ]
      }
    ]
  } 
} 
```

...all the matched pre-existing partitions are considered as candidates
to be shrunk.

## Solution

With this fix, partitions with no actions do not generate any SpaceMaker
action.

## Bonus

`AgamaProposal` now returns an exception of type
`Y2Storage::NoDiskSpaceError` when the SpaceMaker fails to find space.
That was the documented behavior, but a generic `Y2Storage::Error` was
returned instead.

## Testing

- Added a new unit test
- Tested manually

Run Details

9 of 9 new or added lines in 2 files covered. (100.0%)

6 existing lines in 3 files now uncovered.

16919 of 23715 relevant lines covered (71.34%)

35.93 hits per line