agama-project / agama / 11838245526

68%

push

github

AgamaProposal: Honor DiskAnalyzer candidate devices when searching drives (#1765)

## Problem

When searching drives, the initial implementation of `AgamaProposal`
uses all disk (or disk-like devices, to be precise) in the system.

That is ok as a first attempt, but we always knew we might need to
refine that a bit.

Now that we are working on the new interface for storage configuration,
fully based on `AgamaProposal`, the fact that `AgamaProposal` can choose
a disk that is not considered by `DiskAnalyzer` to be an installation
candidate feels a bit odd.

## Solution

For the time being (and with minimal code changes), this adapts the
`AgamaProposal` algorithm to filter out disks that are skipped by
`DiskAnalyzer`. That typically means the disks from which the installer
is running, disks that contain installation repositories, etc.

We may need to refine that in the future again. But for now that's the
most consistent behavior we can adopt without taking big decisions.

## Testing

Added a new unit test

Manual testing done by @joseivanlopez.

12 of 12 new or added lines in 2 files covered. (100.0%)

16915 of 23707 relevant lines covered (71.35%)

35.84 hits per line