agama-project / agama / 11842624800

68%

push

github

Small wireless configuration fixes (#1753)

## Problem

- https://trello.com/c/5PjJQ2Vq

There are various issues detected when working on this PBI:

1. The authentication method is not selected properly
2. The form reports that auhentication failed when it is already
connected.
3. Some times the labels and buttons for the selected wifi does not
correspond whith the current state.
4. After a sync with master branch the backend started failing when
reading wireless connections

## Solution

We have fixes some of the issues but the handle of state is quite
fragile and coupled to the websockets notification in the frontend and
the UI therefore we plan to do some changes in the UI (Drawer and
selection of the WiFi) as well as in the backend trying to store the
authentication state there being able to request the state from the
backend without lostling any information in case of not subscribed to
changes.

About the fixes in particular:

1. The authentication method is recognized again (removed method
probably by error).
2. In case that a wireless device is activated the needAuth is also
removed from the cached queries
3. To be better handled.
4. Get some of the wireless settings as optional (band, channel, bssid,
hidden, pmf)

...

## Testing

- Tested manually

8 of 8 new or added lines in 1 file covered. (100.0%)

16922 of 23718 relevant lines covered (71.35%)

35.93 hits per line