pantsbuild / pants / 6858

0%

main: 93%

push

travis-ci

Fix coordinates of resolved jars in IvyInfo.

Previously `IvyInfo.get_resolved_jars_for_jar_library` would copy the
dependee's coordinate to all artifacts in its dependency graph.  Added a
failing unit test that this change fixed.

Also moved the test data used in this test into the same dir tree.

Testing Done:
Before the fix, the new test failed as such:
```
>     self.assertEqual(expected, coordinate_by_path)
E     AssertionError: {u'ivy2cache_path/org3/name3.jar': M2Coordinate(org=u'org3', name=u'name3', rev= [truncated]... != {'ivy2cache_path/org3/name3.jar': M2Coordinate(org=u'org1', name=u'name1', rev=u [truncated]...
E     - {u'ivy2cache_path/org1/name1.jar': M2Coordinate(org=u'org1', name=u'name1', rev=u'0.0.1', classifier=None, type_=u'jar'),
E     ?  -
E
E     + {'ivy2cache_path/org1/name1.jar': M2Coordinate(org=u'org1', name=u'name1', rev=u'0.0.1', classifier=None, type_=u'jar'),
E     -  u'ivy2cache_path/org2/name2.jar': M2Coordinate(org=u'org2', name=u'name2', rev=u'0.0.1', classifier=None, type_=u'jar'),
E     ?  -                                                       ^              ^
E
E     +  'ivy2cache_path/org2/name2.jar': M2Coordinate(org=u'org1', name=u'name1', rev=u'0.0.1', classifier=None, type_=u'jar'),
E     ?                                                         ^              ^
E
E     -  u'ivy2cache_path/org3/name3.jar': M2Coordinate(org=u'org3', name=u'name3', rev=u'0.0.1', classifier=None, type_=u'jar')}
E     ?  -                                                       ^              ^
E
E     +  'ivy2cache_path/org3/name3.jar': M2Coordinate(org=u'org1', name=u'name1', rev=u'0.0.1', classifier=None, type_=u'jar')}
E     ?                                                         ^              ^
```

CI went green here:
  https://travis-ci.org/pantsbuild/pants/builds/80342136

Bugs closed: 1841, 2193

Reviewed at https://rbcommons.com/s/twitter/r/2818/

27 of 27 new or added lines in 2 files covered. (100.0%)

17758 of 23517 relevant lines covered (75.51%)

1.43 hits per line