pantsbuild / pants / 6859

0%

main: 93%

push

travis-ci

Kill 'ivy_resolve_symlink_map' and 'ivy_cache_dir' products.

The 'ivy_cache_dir' product was unused within pants and anyone in need
of this info can consult the IvySubsystem.

The 'ivy_resolve_symlink_map' product was unused except internally to
the `IvyTaskMixin`/`IvyResolve` - switch to a normal return parameter
and kill the one unused task dependency on the product.  As a result,
simplify symlink handling which no longer is multi-pass as is made clear
by the product collapse.

Testing Done:
Ran `./pants test tests/python/pants_test/backend/jvm/tasks::` locally.

CI went green here:
  https://travis-ci.org/pantsbuild/pants/builds/80342767

Bugs closed: 1841, 2195

Reviewed at https://rbcommons.com/s/twitter/r/2819/

29 of 29 new or added lines in 4 files covered. (100.0%)

17746 of 23502 relevant lines covered (75.51%)

1.43 hits per line