• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

pantsbuild / pants / 6857
0%
main: 93%

Build:
Build:
LAST BUILD BRANCH: uv-lockfile-resolver
DEFAULT BRANCH: main
Ran 15 Sep 2015 02:37AM UTC
Jobs 10
Files 391
Run time 252min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
6857

push

travis-ci

stuhood
Fix `NailgunExecutor` to support more than one connect attempt

In 73e25e74, the `WAIT_INTERVAL` field of `ProcessManager` was renamed to
`WAIT_INTERVAL_SEC`, except for one location in `NailgunExecutor` which broke as
a result.  This causes the `try_connect` method to fail if one connection
attempt fails, regardless of what the user supplies as the
`--nailgun-connect-attempts` flag on the command line.

Testing Done:
I discovered this issue by using `pylint` and then manually verifying that the warning was correct:

```
$ pylint -E -d no-self-argument src/python/pants/java/nailgun_executor.py
No config file found, using default configuration
************* Module pants.java.nailgun_executor
E:229,17: Instance of 'NailgunExecutor' has no 'WAIT_INTERVAL' member
(no-member)
```

After fixing the issue the `pylint` warning disappears:

```
$ pylint -E -d no-self-argument src/python/pants/java/nailgun_executor.py
No config file found, using default configuration
```

Bugs closed: 2196

Reviewed at https://rbcommons.com/s/twitter/r/2822/

1 of 1 new or added line in 1 file covered. (100.0%)

17750 of 23506 relevant lines covered (75.51%)

1.43 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
1
100.0
src/python/pants/java/nailgun_executor.py
Jobs
ID Job ID Ran Files Coverage
1 6857.1 (CI_FLAGS="-cjlpn 'Various pants self checks'") 15 Sep 2015 02:37AM UTC 0
Travis Job 6857.1
2 6857.2 (CI_FLAGS="-fkmsrcn -u 0/2 'Unit tests for pants and pants-plugins - shard 1'") 15 Sep 2015 02:40AM UTC 0
70.93
Travis Job 6857.2
3 6857.3 (CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'") 15 Sep 2015 02:39AM UTC 0
71.64
Travis Job 6857.3
4 6857.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'") 15 Sep 2015 02:38AM UTC 0
Travis Job 6857.4
5 6857.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'") 15 Sep 2015 02:41AM UTC 0
Travis Job 6857.5
6 6857.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'") 15 Sep 2015 02:44AM UTC 0
Travis Job 6857.6
7 6857.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'") 15 Sep 2015 02:46AM UTC 0
Travis Job 6857.7
8 6857.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'") 15 Sep 2015 02:47AM UTC 0
Travis Job 6857.8
9 6857.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'") 15 Sep 2015 02:45AM UTC 0
Travis Job 6857.9
10 6857.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'") 15 Sep 2015 02:47AM UTC 0
Travis Job 6857.10
Source Files on build 6857
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #6857
  • a86d0ad3 on github
  • Prev Build on master (#6854)
  • Next Build on master (#6858)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc