2
0%
main: 93%

Ran 15 Sep 2015 02:40AM UTC

Files 391

Run time 249min

Badge

Embed ▾

Committed 15 Sep 2015 02:31AM UTC coverage: 70.927%. Remained the same

Job # CI_FLAGS="-fkmsrcn -u 0/2 'Unit tests for pants and pants-plugins - shard 1'"

Build Type

push

travis-ci

Committed by

stuhood

Commit Message

Fix `NailgunExecutor` to support more than one connect attempt

In 73e25e74, the `WAIT_INTERVAL` field of `ProcessManager` was renamed to
`WAIT_INTERVAL_SEC`, except for one location in `NailgunExecutor` which broke as
a result.  This causes the `try_connect` method to fail if one connection
attempt fails, regardless of what the user supplies as the
`--nailgun-connect-attempts` flag on the command line.

Testing Done:
I discovered this issue by using `pylint` and then manually verifying that the warning was correct:

```
$ pylint -E -d no-self-argument src/python/pants/java/nailgun_executor.py
No config file found, using default configuration
************* Module pants.java.nailgun_executor
E:229,17: Instance of 'NailgunExecutor' has no 'WAIT_INTERVAL' member
(no-member)
```

After fixing the issue the `pylint` warning disappears:

```
$ pylint -E -d no-self-argument src/python/pants/java/nailgun_executor.py
No config file found, using default configuration
```

Bugs closed: 2196

Reviewed at https://rbcommons.com/s/twitter/r/2822/

Run Details

16672 of 23506 relevant lines covered (70.93%)

0.71 hits per line

pantsbuild / pants / 6857 / 2
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 6857.2 (CI_FLAGS="-fkmsrcn -u 0/2 'Unit tests for pants and pants-plugins - shard 1'")

pantsbuild / pants / 6857 / 2 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 6857.2 (CI_FLAGS="-fkmsrcn -u 0/2 'Unit tests for pants and pants-plugins - shard 1'")

pantsbuild / pants / 6857 / 2
0%
main: 93%

README BADGES
x