14
99%
master: 97%

Ran 28 Oct 2020 10:03AM UTC

Files 101

Run time 21s

Badge

Embed ▾

Committed 28 Oct 2020 07:43AM UTC coverage: 99.154%. Remained the same

Job # 2.6.6, gemfiles/rails_6.gemfile

Build Type

push

travis-ci

Committed by

dnesteryuk

Commit Message

fix a performance issue with dependent params

Fixes https://github.com/ruby-grape/grape/issues/2100

The reason was in `ActiveSupport::HashWithIndifferentAccess`, it
is super expensive.

When users use a `Grape::Extensions::ActiveSupport::HashWithIndifferentAccess::ParamBuilder`
or `Grape::Extensions::Hashie::Mash::ParamBuilder` parameter builder
there is no change. However, users who use `Grape::Extensions::Hash::ParamBuilder`
must make sure a parameter to be dependent on must be a symbol.

    given :matrix do
      # block here
    end

Benchmark after this fix:

Warming up --------------------------------------
               Given     1.000  i/100ms
              Simple     1.000  i/100ms
Calculating -------------------------------------
               Given      0.804  (± 0.0%) i/s -     49.000  in  61.186831s
              Simple      0.855  (± 0.0%) i/s -     52.000  in  60.926097s

Comparison:
              Simple:        0.9 i/s
               Given:        0.8 i/s - 1.06x  slower

Run Details

12426 of 12532 relevant lines covered (99.15%)

2.04 hits per line

ruby-grape / grape / 4213 / 14
99%
master: 97%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 4213.14 (2.6.6, gemfiles/rails_6.gemfile)

ruby-grape / grape / 4213 / 14 99% master: 97%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 4213.14 (2.6.6, gemfiles/rails_6.gemfile)

ruby-grape / grape / 4213 / 14
99%
master: 97%

README BADGES
x