5352
0%
main: 93%

Ran 17 Jun 2015 09:52PM UTC

Jobs 10

Files 331

Run time 16min

Badge

Embed ▾

pending completion

Build # 5352

Build Type

push

travis-ci

Committed by stuhood

Commit Message

Fix bad logger.debug call in artifact_cache.py

- Fix a debug-level call in artifact_cache.py that explodes when pants is run at `-ldebug`

Sidenote, there are a _lot_ of calls that use string formatting rather than any type of logger-supported interpolation that would be skipped when a particular log level is disabled. I suspect that this has a very significant performance cost.

      File "/Users/stuhood/Python/CPython-2.7.8/lib/python2.7/logging/__init__.py", line 859, in emit
        msg = self.format(record)
      File "/Users/stuhood/Python/CPython-2.7.8/lib/python2.7/logging/__init__.py", line 732, in format
        return fmt.format(record)
      File "/Users/stuhood/Python/CPython-2.7.8/lib/python2.7/logging/__init__.py", line 471, in format
        record.message = record.getMessage()
      File "/Users/stuhood/Python/CPython-2.7.8/lib/python2.7/logging/__init__.py", line 335, in getMessage
        msg = msg % self.args
    TypeError: not all arguments converted during string formatting
    Logged from file artifact_cache.py, line 82

Reviewed at https://rbcommons.com/s/twitter/r/2386/

Coverage Stats

13990 of 19825 relevant lines covered (70.57%)

1.32 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	5352.1 (CI_FLAGS="-cjlpn 'Various pants self checks'")	17 Jun 2015 09:52PM UTC		Travis Job 5352.1
2	5352.2 (CI_FLAGS="-fkmsrcn -u 0/2 'Unit tests for pants and pants-plugins - shard 1'")	17 Jun 2015 09:52PM UTC	66.74	Travis Job 5352.2
3	5352.3 (CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'")	17 Jun 2015 10:00PM UTC	65.65	Travis Job 5352.3
4	5352.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'")	17 Jun 2015 09:58PM UTC		Travis Job 5352.4
5	5352.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'")	17 Jun 2015 10:02PM UTC		Travis Job 5352.5
6	5352.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'")	17 Jun 2015 10:05PM UTC		Travis Job 5352.6
7	5352.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'")	17 Jun 2015 10:06PM UTC		Travis Job 5352.7
8	5352.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'")	17 Jun 2015 10:07PM UTC		Travis Job 5352.8
9	5352.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'")	17 Jun 2015 10:08PM UTC		Travis Job 5352.9
10	5352.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'")	17 Jun 2015 10:08PM UTC		Travis Job 5352.10

Source Files on build 5352

Detailed source file information is not available for this build.

pantsbuild / pants / 5352
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 5352

pantsbuild / pants / 5352 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 5352

pantsbuild / pants / 5352
0%
main: 93%

README BADGES
x