5353
0%

Ran 17 Jun 2015 10:13PM UTC

Jobs 10

Files 331

Run time 8min

Badge

Embed ▾

pending completion

Build # 5353

Build Type

push

travis-ci

Committed by Eric Ayers

Commit Message

Fixed the error messages in assert_list().

Add a key field to the error messages in assert_list() function in validation.py

Testing Done:
When calling the assert_list() function in validation.py, the user didn't have access to the keyword in which the specific error happened, thus making it harder to debug. I have added a key argument param to this function and to the error message to make the message more specific.

current error message:
```
Exception message: Expected an object of acceptable type (<type 'list'>, <class 'twitter.common.dirutil.fileset.Fileset'>, <class 'pants.backend.core.wrapped_globs.FilesetWithSpec'>, <class 'twitter.common.collections.orderedset.OrderedSet'>, <type 'set'>, <type 'tuple'>), received examples/src/python/hello/greet instead
```

expected modified error message:
```
Exception message: In key 'sources': Expected an object of acceptable type (<type 'list'>, <class 'twitter.common.dirutil.fileset.Fileset'>, <class 'pants.backend.core.wrapped_globs.FilesetWithSpec'>, <class 'twitter.common.collections.orderedset.OrderedSet'>, <type 'set'>, <type 'tuple'>), received examples/src/python/hello/greet instead
```

(the key argument has been added to the error message)

Error encountered in issue #642

Bugs closed: 1673

Reviewed at https://rbcommons.com/s/twitter/r/2370/

Run Details

13962 of 19830 relevant lines covered (70.41%)

1.32 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	5353.1 (CI_FLAGS="-cjlpn 'Various pants self checks'")	17 Jun 2015 10:13PM UTC	0		Travis Job 5353.1
2	5353.2 (CI_FLAGS="-fkmsrcn -u 0/2 'Unit tests for pants and pants-plugins - shard 1'")	17 Jun 2015 10:13PM UTC	331	66.22	Travis Job 5353.2
3	5353.3 (CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'")	17 Jun 2015 10:14PM UTC	331	65.79	Travis Job 5353.3
4	5353.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'")	17 Jun 2015 10:14PM UTC	0		Travis Job 5353.4
5	5353.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'")	17 Jun 2015 10:15PM UTC	0		Travis Job 5353.5
6	5353.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'")	17 Jun 2015 10:20PM UTC	0		Travis Job 5353.6
7	5353.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'")	17 Jun 2015 10:21PM UTC	0		Travis Job 5353.7
8	5353.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'")	17 Jun 2015 10:21PM UTC	0		Travis Job 5353.8
9	5353.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'")	17 Jun 2015 10:20PM UTC	0		Travis Job 5353.9
10	5353.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'")	17 Jun 2015 10:21PM UTC	0		Travis Job 5353.10

Source Files on build 5353

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

pantsbuild / pants / 5353
0%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 5353

pantsbuild / pants / 5353 0%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 5353

pantsbuild / pants / 5353
0%

README BADGES
x