5351
0%
main: 93%

Ran 17 Jun 2015 08:38PM UTC

Jobs 10

Files 331

Run time 11min

Badge

Embed ▾

pending completion

Build # 5351

Build Type

push

travis-ci

Committed by Benjy

Commit Message

Simplify subsystem option scoping.

This gets rid of the concept of "scope qualifiers", which was mostly just confusing.
Now subsystems just have scopes ('ivy', 'scala-platform' etc.) and task-specific
instances have options in the appropriate subscope (e.g., `cache.compile.java` instead of
`compile.java.cache` as it was previously). This has many advantages:
  - Option value inheritance "just works": `cache.compile.java` will inherit values from
   `cache`, in the usual way.
  - Overriding values in the subscope will also work as it does today - by registering
    the option as recursive=True.
  - Code is simpler, with a net reduction in LoC: "82 insertions(+), 114 deletions(-)".
  - Subsystems and tasks are now more uniform. For example, both just have an options_scope
     property, instead of one having a scope_qualifier() method.

This change doesn't affect any existing pants.ini or flags because we don't have any
task-specific subsystem instances yet.

It does mean that the section name for a task-specific config would be
[cache.compile.java], not [compile.java.cache], but that doesn't seem like a big deal.

Testing Done:
All unit tests pass locally.

CI passes here: https://travis-ci.org/pantsbuild/pants/builds/67110458.

Reviewed at https://rbcommons.com/s/twitter/r/2380/

Coverage Stats

13411 of 19825 relevant lines covered (67.65%)

1.17 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	5351.1 (CI_FLAGS="-cjlpn 'Various pants self checks'")	17 Jun 2015 08:42PM UTC		Travis Job 5351.1
2	5351.2 (CI_FLAGS="-fkmsrcn -u 0/2 'Unit tests for pants and pants-plugins - shard 1'")	17 Jun 2015 08:38PM UTC	50.84	Travis Job 5351.2
3	5351.3 (CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'")	17 Jun 2015 08:40PM UTC	65.7	Travis Job 5351.3
4	5351.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'")	17 Jun 2015 08:41PM UTC		Travis Job 5351.4
5	5351.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'")	17 Jun 2015 08:43PM UTC		Travis Job 5351.5
6	5351.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'")	17 Jun 2015 08:45PM UTC		Travis Job 5351.6
7	5351.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'")	17 Jun 2015 08:46PM UTC		Travis Job 5351.7
8	5351.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'")	17 Jun 2015 08:48PM UTC		Travis Job 5351.8
9	5351.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'")	17 Jun 2015 08:49PM UTC		Travis Job 5351.9
10	5351.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'")	17 Jun 2015 08:49PM UTC		Travis Job 5351.10

Source Files on build 5351

Detailed source file information is not available for this build.

pantsbuild / pants / 5351
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 5351

pantsbuild / pants / 5351 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 5351

pantsbuild / pants / 5351
0%
main: 93%

README BADGES
x