pantsbuild / pants / 5351 / 2
0%
main: 93%

LAST BUILD BRANCH: jason/log-batches
DEFAULT BRANCH: main
Ran
Files 331
Run time 16s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 50.845% (-15.9%) from 66.756%
CI_FLAGS="-fkmsrcn -u 0/2 'Unit tests for pants and pants-plugins - shard 1'"

push

travis-ci

Benjy 
Simplify subsystem option scoping.

This gets rid of the concept of "scope qualifiers", which was mostly just confusing.
Now subsystems just have scopes ('ivy', 'scala-platform' etc.) and task-specific
instances have options in the appropriate subscope (e.g., `cache.compile.java` instead of
`compile.java.cache` as it was previously). This has many advantages:
  - Option value inheritance "just works": `cache.compile.java` will inherit values from
   `cache`, in the usual way.
  - Overriding values in the subscope will also work as it does today - by registering
    the option as recursive=True.
  - Code is simpler, with a net reduction in LoC: "82 insertions(+), 114 deletions(-)".
  - Subsystems and tasks are now more uniform. For example, both just have an options_scope
     property, instead of one having a scope_qualifier() method.

This change doesn't affect any existing pants.ini or flags because we don't have any
task-specific subsystem instances yet.

It does mean that the section name for a task-specific config would be
[cache.compile.java], not [compile.java.cache], but that doesn't seem like a big deal.

Testing Done:
All unit tests pass locally.

CI passes here: https://travis-ci.org/pantsbuild/pants/builds/67110458.

Reviewed at https://rbcommons.com/s/twitter/r/2380/

10080 of 19825 relevant lines covered (50.84%)

0.51 hits per line

Source Files on job 5351.2 (CI_FLAGS="-fkmsrcn -u 0/2 'Unit tests for pants and pants-plugins - shard 1'")